Merchant Issues Thread

[John Adams]

We'll keep issues with merchants compiled here.

- The deal with the popup full Examine window on mouse-over is super annoying, and probably a simple fix. Can we get that one resolved soon? I tried to figure it out myself, but it's over my head as usual :/ I think it has something to do with the examine type being sent on the mouse-over (mini-examine). There is another thread about this if you need more detail.

• Btw, I think this only happens on items in the Buy tab - I do not see it popping up full examine on Sell or Buy Back
  
  Ok, about this heh... the reason it's not popping the full examine on mouse-over for Sell is that it is not properly building the examine tooltip anyway. That, and maybe it also happens to be the right examine type for Sell =) Here's two examples, one of Beta Voucher for Buy, and the other for Sell.
  merchant3.jpg
  merchant4.jpg

- Item stacks DO appear on the merchant window, but not in the player inventory. So does that mean the items data is correct, and it's just a server-to-client display problem?

- As a new toon, I get a stack of 20 'flask of water' to start. If I /summon another of the same type, then go to Sell to Merchant, I cannot select the top-most 'flask of water' item if I have the second one selected. Like the list is getting confused.

- "Not for sale" issues:

• does not stick after you have closed the merchant window and re-open it
  needs to replace the coin value with the text "Not for sale" in both the item list and below the detail.
  see this before/after screenies
  merchant1.jpg
  merchant2.jpg

- Buy Back is supposed to sell the entire stack back to you if you Buy Back anything stackable (just verified on Live). So while "Buy" is the only option on Buy Back, whatever the quantity is in the line gets bought when you click Buy. Currently, Buy only buys 1 item at a time from a stack.

• Update: (03/01/2009) Buy on the Buy Back tab shows the total coin to buy back the entire stack, but only buys 1 item - though it deducts the price of the entire stack as if it bought all 20.
  Also now it appears my inventory is showing the full stack purchased, so I think it's just not removing it from buyback.
  buyback1.jpg

- Even after I sold an entire stack to the merchant, then tried to Buy Back the stack (and got only 1 according to the merchant UI), when I went to delete the water stack I sold, the Destroy dialog offered that I was destroying 19 waters, when I should have only had 1.

- Some vendors are showing the Sell tab first. Most are ok. Not sure what is causing this odd behavior, but it is consistent (always happens on the same vendor, not inconsistently).

- "sell to merchant" menu item still lands on "Buy" tab - likely the entity_commands handler?

- Merchants with merchant_id assigned but no merchants inventory built, show the contents of the previous vender viewed instead of an empty window. And, the initial Sell tab does not show player items to sell until you switch to Buy Back and back to Sell (rev 267).

- NO TRADE items can be sold? Is that correct?


- [Feature Request] Cannot buy or sell with Status Points - not a bug, but something to implement.

- [Feature Request] Some merchants in live do not offer any goods unless you have faction/status/class(race?) Need the ability to limit merchant lists. My gal just told me about a merchant that "does not want your business", so either that is faction or race, eh?

- [Feature Request] Separating Class, as it is likely more needed right away than faction. Spell Scroll merchants have lists of everyone's App2's I imagine - but when a Guardian clicks that merchant, only his/her spells are available for sale. We need to hook merchant Items into `skill_req` perhaps to limit these merchant lists, but only on specific merchant types.

- [Feature Request] Make sure merchant item lists allow the Dressing Room option if available for the item. I don't know if Dressing Room works for us now, cuz I cannot get it to pop up yet.

- [Feature Request] Add support for Repair dialog (not full functionality, just UI window will do for now)

- [Feature Request] Add support for Broker dialog (not full functionality, just UI window will do for now)

[Scatman]

Tonight I was buying stuff from merchants on Tess. I had 1,000 platinum and was buying something for 2 silver. Everytime I buy it, it takes 2 copper away instead of 2 silver. Also, with my quest reward of 1,000 platinum, I get 1,000 gold instead. Everything seems to be shifted down one. Could this just be a struct that got changed?

[John Adams]

LE, can we get some of your time today (Sun) to look at two merchant issues? This one Scat is talking about seems pretty important for testing.

The other one I would really like put behind us is the mouse-over examine for merchant items - mostly the fact a full examine pops up on each mouse-over. It is a real headache when working with merchant lists.

Thanks

[LethalEncounter]

Tonight I was buying stuff from merchants on Tess. I had 1,000 platinum and was buying something for 2 silver. Everytime I buy it, it takes 2 copper away instead of 2 silver. Also, with my quest reward of 1,000 platinum, I get 1,000 gold instead. Everything seems to be shifted down one. Could this just be a struct that got changed?

Yah the struct probably changed and if so it is simply a display issue and shouldn't affect the value in the db for your coin values.

[John Adams]

You can see in all my previous screen shots, the tabs are Buy, Sell, Buy Back (if any items are listed).

I am opening the Mushroom Vendor in GFay and for a flash, I see Buy, Sell, Buy Back - but then it quickly changes to this:

buy-tab.jpg

Another vendor in this zone (Breezebloom), her tabs are proper. Not sure what is making this one look strange.

[John Adams]

Another little bug. When using the right-click and selecting "sell to merchant", you are still dropped on the Buy tab. In Live, you are sent directly to the Sell tab (or at least you were last time I sold something :p )

[John Adams]

Jeepers. Quite by accident here's another merchant bug heh. sorry.

I had a merchant that didn't have a merchant_id assignment (but had the command_primary for buy). so I assigned a new merchant list but with no items. I would fill in the items list later.

After respawning, the vendor window now comes up but has the contents of the last vendor I viewed, since this merchant list is empty - I presume.

Perhaps clearing the merchant window (buffer) on close would solve this.

[LethalEncounter]

Jeepers. Quite by accident here's another merchant bug heh. sorry.

I had a merchant that didn't have a merchant_id assignment (but had the command_primary for buy). so I assigned a new merchant list but with no items. I would fill in the items list later.

After respawning, the vendor window now comes up but has the contents of the last vendor I viewed, since this merchant list is empty - I presume.

Perhaps clearing the merchant window (buffer) on close would solve this.

There is not any kind of buffer for these. The list is sent based on the currently selected spawn. The only way I could see this happening is if you had the previous spawn selected and then you somehow activated the menu for the new spawn without updating your target.

[John Adams]

Well, "buffer" is just my layman terminology. You saying you do not load the merchant items into an array and send it to the client? Maybe it is a fault in the client then that if it does not get another new list from the server, it just displays what it last knew.

And no, I am definitely highlighting the new vendor, hitting H to hail (test script) and then single-clicking to get the window to come up. So it is not an old target, for sure.

It may be the former, and if so, nothing we should do about it but provide a merchant list with something in it.

[John Adams]

LE, I am adding to the opening post as I find things, just in case you miss them. The bottom of the post are Feature Requests only, so nothing urgent. Just making a list so we know what we need eventually.

[LethalEncounter]

You saying you do not load the merchant items into an array and send it to the client?

I do, but it generates the list whenever a client initiates a merchant session. It gets the list by the current target's merchant_id. That is why it is odd that the server could seemingly do what you described. :/

[John Adams]

Ok, so if I start a merchant session with a spawn.merchant_id, but nothing associated in the merchants table, should I see an empty merchant window? That's what I thought would happen, but it's not. Maybe the client is caching it?

[John Adams]

I just assigned all merchants on Tess to a merchant_id 1, which basically just makes their windows come up. They have no inventory, yet.

I noticed when I opened the merchant window, the Sell tab is displayed first, because there are no items. This is ok.

What is not ok is that none of the player items available for sale show up, until you click to Buy Back, then back to Sell. Looks like the merchant list is only pushing display for Buy items, and not sell - which may be fixed once the code is in place to handle going directly to "Sell to merchant" from right-click.

Updated opening post with this new merchant bug.


Edit: Also, when I did try to sell items, I noticed stacks are still not reported properly... and NO TRADE items were allowed to be sold (though I am not positive that is wrong... is it?)

[LethalEncounter]

KK, I'll take a look at it. No Trade items should still be sellable I think, just not tradeable to other players. No value items, however, cannot be sold.

[Zcoretri]

KK, I'll take a look at it. No Trade items should still be sellable I think, just not tradeable to other players. No value items, however, cannot be sold.

Just wanted to clarify, NO VALUE items can be sold on broker to other players, just not to merchants.