BugID: 458 (Scatman) /reload items crashes the server

[ZexisStryfe]

Bug ID: 458 - /reload items crashes the server
Bug Date: 2010-03-09 18:37:04
Priority: Critical

Originated From World: Sytherian Legends (190)
Category: Mechanics
Sub-Category: Items
Causes a Crash: Causes crash
Reproducible: Always Happens
Version: SOEBuild=6196L

Details:
As of SVN 410 using the /reload items command kicks the user and won't let them log back in. I believe it is crashing the entire server.
Spawn: N/A (0), Zone: Scar Crescent

[John Adams]

Here's a dump from linux, where I just confirmed the same behavior:

Code: Select all

[20100309 19:57:42] [Status] OP_Unknown Received 0179
   0: 00 00                                              | ..
   0: 09 01 00 00                                        | ....
   0: 25 00 01 00 30                                     | %...0
   0: 23 00 01 00 31                                     | #...1
   0: 41 00 05 00 69 74 65 6D - 73                       | A...items
[20100309 19:57:57] [Status] Reloading items..

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb3e97b70 (LWP 4367)]
0xb7f80d35 in std::basic_string<char, std::char_traits<char>, std::allocator<cha                                                                                                                               r> >::~basic_string() () from /usr/lib/libstdc++.so.6
(gdb) bt
#0  0xb7f80d35 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::~basic_string() () from /usr/lib/libstdc++.so.6
#1  0x080f83be in ~EQ2_16BitString (this=0x8a628f8,
    __in_chrg=<value optimized out>) at ../common/types.h:163
#2  ~Book_Info (this=0x8a628f8, __in_chrg=<value optimized out>) at Items.h:513
#3  ~Item (this=0x8a628f8, __in_chrg=<value optimized out>) at Items.cpp:595
#4  0x080f8fea in MasterItemList::RemoveAll (this=0x82f0c5c) at Items.cpp:536
#5  0x08187802 in WorldDatabase::ReloadItemList (this=0x82f1000)
    at WorldDatabase.cpp:495
#6  0x080de34f in Commands::Process (this=0x82f0ee0, index=65,
    command_parms=0xb3e970c4, client=0xaf88bc0) at Commands.cpp:2799
#7  0x0812902a in Client::HandlePacket (this=0xaf88bc0, app=0xf68bf38)
    at client.cpp:1107
#8  0x0812cb97 in Client::Process (this=0xaf88bc0, zone_process=true)
    at client.cpp:1599
#9  0x081d6acb in ZoneServer::ClientProcess (this=0x8bae5e0)
    at zoneserver.cpp:1857
#10 0x081d7273 in ZoneServer::Process (this=0x8bae5e0) at zoneserver.cpp:870
#11 0x081d7706 in ZoneLoop (tmp=0x8bae5e0) at zoneserver.cpp:3838
#12 0xb7c6880e in start_thread () from /lib/tls/i686/cmov/libpthread.so.0
#13 0xb7bea8de in clone () from /lib/tls/i686/cmov/libc.so.6

[John Adams]

And who gave this guy access to submit AND escalate his own bugs, anyway!?

[ZexisStryfe]

I only escalate the major issues... the annoying little things I will wait for you to deal with

By the way, tested this on 409 and it crashes the server there too.

[Scatman]

I'll try and take a look at this tomorrow. I've been trying to get a chance to look at our in-depth showstoppers (multiple spawns, minilogin etc) but I keep getting distracted (/smack self!). If it's an easy fix, which I hope it is, I'll fix her right away. Unless this bug crashes the server more often? You guys let me know, what's #1.

[John Adams]

Since Players cannot /reload on Tess, it is not that critical for me - but for those developing their own content, /reload is a must. I'd say anything that *crashes* the server takes priority over anything else. That's always been my stance, anyway.

You'll get it, Scatman! I have teh faithz!

[Scatman]

Should be fixed.