BugID: 317

Old bugs stored here for reference.
Locked
User avatar
elcapototal
Retired
Posts: 27
Joined: Tue Mar 23, 2010 1:16 pm
EQ2Emu Server: Angphax
Characters: Elcapototal
Location: New York City

BugID: 317

Post by elcapototal » Wed Mar 24, 2010 10:40 am

Not sure how to send code fixes for small bugs. Diffs are a pain in the butt for 1-liners so for the time being I'm just going to post the new code and line numbers. if this doesn't work for you guys let me know and I'll just generate the diffs.

Fix for 317 (/summon bug):

Client.cpp
Summon function
added lines 1867 & 1868

Code: Select all

1866.			target = GetCurrentZone()->FindSpawn(GetPlayer(), search_name);
1867.			if(target && target->IsPlayer())
1868.				search_client = GetCurrentZone()->GetClientBySpawn(target);
1869.			if(!target){
1870.				search_client = zone_list.GetClientByCharName(string(search_name));
1871.				if(search_client)
1872.					target = search_client->GetPlayer();
1873.			}

User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

Re: BugID: 317

Post by John Adams » Wed Mar 24, 2010 11:01 am

Please generate diffs for code submissions. If you are using TortoiseSVN client, it is as easy as highlighting the Source dir and Create patch. The reason this is important is that our line #'s are likely not going to match the public SVN, and I do not want our dev(s) diving through code making guesses - diffs are fairly standard, so I am sure you'll understand.

Let us know if you have any questions about this. And thank you in advance for the code fixes!

User avatar
elcapototal
Retired
Posts: 27
Joined: Tue Mar 23, 2010 1:16 pm
EQ2Emu Server: Angphax
Characters: Elcapototal
Location: New York City

Re: BugID: 317

Post by elcapototal » Wed Mar 24, 2010 11:39 am

attached patch
You do not have the required permissions to view the files attached to this post.

User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

Re: BugID: 317

Post by John Adams » Wed Mar 24, 2010 11:45 am

Awesome, thank you. These take a little longer than simple DB updates to apply :) Give is a few to sort it out.

SCAT!

Locked

Who is online

Users browsing this forum: No registered users and 0 guests