BugID: 559 (Scatman) Breathing

[John Adams]

Bug ID: 559 - Breathing
Bug Date: 2011-07-14 15:16:50
Priority: Critical

Originated From World: EQ2Emu DB Project (906)
Category: Mechanics
Sub-Category: Other
Causes a Crash: Affects gameplay
Reproducible: Always Happens
Version: SOEBuild=6563L

Details:
Running out of breath under water is almost instantaneous!
Spawn: N/A (0), Zone: FrostFang Sea

[John Adams]

Entered on Jul 24, 2011 16:07 by John Adams
Breathing underwater seems to still function properly on 5040/6118 clients, only sped up on Halas (SF) clients.

[John Adams]

I have exhausted my searching for Breathing, Swimming, Surfing, Snorkling, or whatever cute variable name LE might have named merely being in water (and UPDATE_ACTIVITY_IN_WATER_BELOW is nowhere in the code aside from the define!) so I need a pointer... Where the hell do we monitor player in water, underwater, while their breathing bar goes down?

Does the client handle all that, and only shoot a command back when we're out of air? If so, how can our world allow normal speed breathing underwater with 6118L and rapid insta-drown with 6563?

Scatto?


PS: I'm suspecting this may be a character sheet value maybe added in the newer clients? maybe it's a mistaken low value, so the player runs out of air instantly? If so, I think we need to bypass drowning for 1096+ data clients for now :/

[Sylva1n]

I noticed the same thing last week on client 6667L

[Scatman]

A drowning player is first found and removed in Player::ProcessMovementData(). It basically adds it to a list in the zone, and that list is processed every so often until you die or you're removed from the list. The client will basically tell the server when you are drowning. So for SF, like you said, a char sheet value may have changed or they meant to process drowning a lot slower than they used to.

[John Adams]

k, well CharacterSheet is somewhere I am not brave enough to go into..., SF client players, don't go swimming

[Zcoretri]

Jabantiz committed a fix for this for 1096 clients. The value is currently hard coded. What needs to be added is support for underwater breathing spells.