BugID: 560 (John Adams) Corpse giving Corpse not lootable warning

[John Adams]

Bug ID: 560 - Corpse giving Corpse not lootable warning
Bug Date: 2011-07-21 19:18:10
Priority: Critical

Originated From World: EQ2Emulator (1)
Category: Content
Sub-Category: Non-Player Character
Causes a Crash: Affects gameplay
Reproducible: Always Happens
Version: SOEBuild=5122L

Details:
Killed many of the scouts, all give a 'You are not allowed to loot at this time' warning
Spawn: a Tunarian scout (2780067), Zone: Outpost of the Overlord

[John Adams]

Entered on Jul 28, 2011 15:07 by John Adams
Putting some debug lines around combat to see if we can track this one down once and for all.

[Jabantiz]

A possible fix for this issue has been commited.

From what I discovered about spawns that aggro you first never being able to be looted along with John discovering that when the first hit doesn't do damage (riposte, parry, dodge, miss, and so on) I believe I was able to determine the cause of this bug. Players are added to the looter list for the spawn when Combat::AddHate() is called, however they are only added if the NPC was not flagged as in combat, in all the cases stated above they were flagged for combat before AddHate was called.

Hopefully this will fix the issue, my tests show promise, but I may have missed a situation so more testing is needed. Leaving this bug open until more testing is done.

[Jabantiz]

Possible fix for when you pull a mob with a spell and the spell is resisted, let me know of any other instances where you should be able to loot but aren't able to.