Implementing: AA/Character Traits

[John Adams]

Thank you, Jabantiz.

Once more question, that I think I asked above in this thread but lost it. The new "spell_traits" table has `level`, `class_req` and `race_req` columns. Is the spell_classes table obsolete now because of that? Meaning, could we either move level and race out of spell_tiers to spell_classes (renaming spell_classes to something more appropriate), and not have these redundant level and class columns for our spells?

I wasn't sure if the Traits* JOIN included spell_classes, and will check later when I get home, unless you answer before then.

Thanks

[Jabantiz]

Level in the spells_trait table IS NOT the level of the spell, it is the level of the choice (Grandmaster spells for example, spell may be lvl 10 but the choice is level 14) as for the rest I am not sure off hand, will have to check it later.

[John Adams]

Level in the spells_trait table IS NOT the level of the spell, it is the level of the choice (Grandmaster spells for example, spell may be lvl 10 but the choice is level 14) as for the rest I am not sure off hand, will have to check it later.

Oh, you mean when you get to select it? Gotcha. Getting ready to push these to DB Patcher, so I wanted to make sure nothing else was off.

Though I discovered there is a missing column in `spell_display_effects` that Zcoretri had, where there is no record of it in Patcher or Code. I believe he added it (or maybe I did?) because the display of the bulleted spell effects were not always in order, and it was a way to force order. Still looking into where that went (I swore we implemented that a year ago)

[Zcoretri]

In the character development tab there are traits...non class or race specific http://eq2.zam.com/wiki/Category:Character_Traits

and traditions...race specific http://eq2.wikia.com/wiki/Traditions

I say we keep them all in the spells table. You will need to modify the editor so we can edit them though.

[John Adams]

Zcoretri, take a quick look at the new Traits editor under Spells.

http://mmoemulators.com:9301/eq2db/editors/spells.php

It's exactly the same as Spells editor, but the filters are different. If you like this layout, I can keep going this way. Or if you'd rather see the data differently, let me know and I'll try it.

[Jabantiz]

[09:20.37] <~john> when you see this, please check out EQ2TC's Character Development screen. I have the data inserted, and I think it's working. BUT... the "groups" are not displaying right, and I still don't see－the Innate options, unless they are now called "Attributes"?

If you ignore the fact I screwed up my DB with the update (already had traits info in there) it all seems to be working correctly. The group column is working right for character traits (if it wasn't the list would be by level all the way down, it is broken up by stats, resists, and regens right now). The only problem I see is innate racial traits do not have the column isInate (yes I spelled it wrong when I created the table...) set to 1, so the code assumes it is just normal racial traits so it is listed under Attributes (group = 0).

It looks like the only race traits currently in the spell_traits table are innate, if that is true then you can simply run this sql.

Code: Select all

UPDATE `spell_traits` SET `isInate`=1 WHERE `race_req` < 255;

but should verify with Zcoretri first that they are all innate traits first.

This reminds me that those groups in normal racial traits (attributes, combat, non-combat, etc) can be customized and should probably be moved from hard coded values to the DB some how.

[John Adams]

This reminds me that those groups in normal racial traits (attributes, combat, non-combat, etc) can be customized and should probably be moved from hard coded values to the DB some how.

Yes, I am not a fan of "hard-coding" anything if we can avoid it. Someone might not want SOE's definition of stuff on their custom server, so see if we can make this more dynamic - unless by some Client restriction, there is no way to customize that data?

What I meant by "wrong" is the list of traits, traditions, class stuff is indeed all run together. top to bottom, no breaks in between to separate one category from the other, and no "Stats", "Resists", "Pools", groupings - unless the 1096 client did not support this?

That's why I asked.

[Jabantiz]

There is no titles for character traits (stats, resists, etc..) this is a pic from live from a few months ago

I think we currently have it looking pretty close to that, if not exact.

[John Adams]

What was I looking at then, which had little yellow titles throughout the page with Stats, Resists, Pools, and other things? Was that an old UI? Wouldn't surprise me at all if SOE changed everything since the last time I was in-game.

[Jabantiz]

I am sure this window has changed before (just changed again on live) but I honestly can't remember what it looked like before this.

[John Adams]

Ok, I just logged into live right now and here is my Character Development screens - exactly how I remembered, and what I am asking about.

You're saying your Live account does not look like this?

altadv1.jpg

altadv2.jpg

altadv3.jpg

[John Adams]

And before you correct me, yes. I do remember "Character Traits" being the big block of buttons I know the UI used to be simpler, and wasn't sure when all the group titles stuff appeared -- which is what I was asking.

[Jabantiz]

We currently don't have data for race traditions, so with no data they don't show. Innate was showing under attributes because they were not flagged as innate, they are set to group = 0 (0 = attributes), if you want change 1 of the innates to group = 1 and the next category will appear (as long as they are not flagged as innate).

[Zcoretri]

So you are saying it doesn't looks like this?

CharDevWindow.png

[Jabantiz]

The update I got looks like it only has innate racial traits, (about 3 or 4 for each race) in the spells_trait table. So no mine does not currently look like that.

EDIT: Just did a search for Brute Force in my DB and came up with nothing, it is in your ss.