BugID: 428 (Jabantiz) Items Disappeared

[John Adams]

Bug ID: 428 - Items Disappeared
Bug Date: 2010-01-23 18:54:17
Priority: High

Originated From World: TessEQ2 (199)
Category: Mechanics
Sub-Category: Items
Causes a Crash: Affects gameplay
Reproducible: Happened Once
Version: SOEBuild=6118L

Details:
After a sudden crash my items disappeared and this random chest thing was in my inventory, and when i hit B a bunch of random bags came up, i looked in my bank to, everything was gone.
Spawn: a Field Investigator (2780174), Zone: Outpost of the Overlord

[John Adams]

This is another version of the items disappearing bug that many others have reported. If the client crashes it seems your stuff goes into limbo. Sometimes. And sometimes when you receive a bag as a reward, you receive it open, or the bag is invisible, or or or about 20 other things wrong with bags. We can consolidate a list of bugs from this forum if we have to.

[John Adams]

I used to see this randomly, too. Stuff disappearing from slots, usually after zone or death/revive. I have since put in some LogWrites to try and catch it, but that's where I left off last year.

[Jabantiz]

Is it possible this has been fixed? Working on LD/revive code where I killed myself countless times and crashed/force disconnect of my client and I haven't lost any items or gained any bags. Or is this a rare bug that doesn't happen that often?

[John Adams]

I seem to remember it happening A LOT long ago. But you're right, I haven't seen it happen in a while. Just keep an eye out, we can close it at the end of 0.7.1 if we never see it again.

[Jabantiz]

I noticed this bug while equiping unequiping items screwing with the stat code I just did, decided to try and reproduce it and fix it and finally got the bag to disappear, hoping packets just got screwed up and that was our issue I moved an item to the spot the bag was hoping it would swap and reappear... that was a mistake, the bag was deleted from my db, items in it are still in the db but the bag is gone meaning those items are out of reach from within game.

This is a serious bug now and I am going to try and track it down and fix it, mainly posting this to warn other and ask, sence I am going to be digging around in item code is there other item bugs I should be aware of or features you all want implemented? (minor features nothing as complex as adorns)

[Jabantiz]

Possible fix for this (hard to test when it is so rare) and a fix for moving item stacks around within bags (thanks xinux for pointing this one out and helping debug it).

[Jabantiz]

Found a crap load of bugs with moving item stacks around... I think I got them all fixed just trying to get the auto inventory working, currently it deletes an item dropped on it, the code I have locally causes stacked items to dupe, trying to figure out another way before I commit these changes.

[Jabantiz]

I just commited fixes for stacked items and auto inventory. There is still some odd behavior in the auto inventory that I need to track down but no items are lost or duped now.

[John Adams]

Awesome! Man that is an old bug. Glad to see it dead

[Jabantiz]

Probably going to use this thread as my general item issues thread now

Fixed an issue that could cause PlayerItemList::HasFreeSlot to return a false posotive, auto inventory should now work properly, and you can no longer put bags with items in it into another bag. The only issue I am aware of right now is if you open an empty bag then move that bag into another bag the window doesn't close, no clue how to force a bag window to close yet. All the fixes are on Dev SVN.

Any other inventory issues that show up let me know and I will try to fix them as soon as possible.