Item stat problems

[thefoof]

Not sure when this bug showed up as I haven't looked at items on the server recently, but item stats aren't showing up right currently and when you go to examine an item with messed up stats it causes a crash. I know it's relatively recent as stats were showing fine not too long ago (maybe within a couple weeks?). This doesn't affect items without stats (such as the starting gear). However I just tried to get a quest from Murrar Shar on Queen's Colony and caused another crash...possibly grabbing reward info(just a guess)?

[Jabantiz]

What client version were you using? Live clients have had struct changes to items already, those structs are used in quest packets, and quest packets love to crash the client when the item struct is off.

[thefoof]

I was using 9570L. I think items were showing fine on that client before though, unless I was just too ignorant to notice it being off but I'm about 99% sure they displayed correctly.

Edit: Let me specify when I say crash I meant client crash, should have been clearer about that

[thefoof]

Here's a couple examples of what I'm seeing, just noticed the name isn't even showing on the popup:

[Jabantiz]

That is definitely a struct issue, if you haven't changed your client and it was working the structs on the server side must have changed. Bad item structs can cause the client to crash when getting a quest or turning in a quest with item rewards.

[thefoof]

I've let jab know this already but just an update I narrowed this problem down to revision 1927 of the itemstructs. The last revision (1923) works fine for the same client.

[John Adams]

Hmm, since 1927 was my commit, I'd like someone to tell me what I did wrong. I made those structs using PacketAnalyzer, and Parser seemed to work fine. Why wouldn't World?

[Jabantiz]

I checked to see if packet type was set in the code for 1199 packets and I checked the struct and they both look good (although I checked the struct with analyzer). I am not sure why it is off only thing I can think of doing is grabbing a log from live and checking our struct against that to see if every thing lines up.

This is probably unrelated but this issue could be happening here as well now, working on the char sheet for 1193 matching the struct up against a packet would not work when the emu sent it, had to manually figure out the locations of stuff wich, in the case of the char sheet, were hundreds of bytes from where it was in the packet. I hope this is not the case for items because if that issue starts to show up in other places then the char sheet it will make things difficult.

[jakalecax]

Confirm still, using DoV and last crash 3/8 was mine, attempting to 'examine' the stats on some higher level stat-ful gear. Sorry

[John Adams]

Don't be sorry, crashes are good for us to solve. They are only bad when developers cannot solve them.

I will re-check the structs on EQ2TC. Thought I fixed that item examine problem.

Edit: Yup, found out my auto update script for Structs was failing, so EQ2TC hadn't had new structs since Jan. That answers a lot of questions.

[jakalecax]

This seems to have disappeared with new VM migration, could not reproduce tonight using same search parameters and items.