World Crash - camping group members

[John Adams]

Xinux crashed EQ2TC again. See his title...

Stack:

> EQ2World.exe!World::RemoveGroupBuffs(PlayerGroup * group, Client * client) Line 1718 + 0x4b bytes C++
EQ2World.exe!World::RemovePlayerFromGroup(PlayerGroup * group, GroupMemberInfo * info, bool erase) Line 1888 C++
EQ2World.exe!World::DisbandGroup(PlayerGroup * group, bool lock) Line 1921 + 0x2e bytes C++
EQ2World.exe!World::DeleteGroupMember(GroupMemberInfo * info) Line 1877 + 0x8 bytes C++
EQ2World.exe!World::RemoveGroupMember(Client * member, bool immediate) Line 1858 C++
EQ2World.exe!ZoneServer::RemoveClient(Client * client) Line 2310 + 0x6 bytes C++
EQ2World.exe!ZoneServer::ClientProcess() Line 2413 C++
EQ2World.exe!ZoneServer::Process() Line 1147 C++
EQ2World.exe!ZoneLoop(void * tmp) Line 5052 + 0xa bytes C++
EQ2World.exe!_callthreadstart() Line 259 + 0x6 bytes C
EQ2World.exe!_threadstart(void * ptd) Line 241 + 0x5 bytes C
kernel32.dll!77e6481f()
[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]

We were testing the new live client structs and cast a few buffs on each other. I was on a mount, and had a pally buff going, not sure what Xinux had. But soon as he camped, the world crashed.

Right here:

Code: Select all

				/* now that we have a spell effect, loop through each group member and see if a group member casted this spell on our leaving group member */
				for (itr = group->members.begin(); itr != group->members.end(); itr++) {
					if ((*itr)->client && (Entity*)((*itr)->client->GetPlayer()) == se[i].caster) {

The *itr is empty