Noticed this in irc last night and looked into it.
Some spell store values as a float, which is sent to the lua script to be used in this function. However this function does not accept floats, only sint16 for value. A simple hack to fix this would be easy but to do it properly a lot of variable types need to be changed, I will work on this later today.
[FIXED]AddSkillBonus
-
Jabantiz
- Lead Developer
- Posts: 2912
- Joined: Wed Jul 25, 2007 2:52 pm
- Location: California
- John Adams
- Retired
- Posts: 9684
- Joined: Thu Jul 26, 2007 6:27 am
- EQ2Emu Server: EQ2Emulator Test Center
- Characters: John
- Location: Arizona
- Contact:
Re: AddSkillBonus
You know my entire existence is to generate more work for you, Jabantiz.
Thank you.
Thank you.
-
Jabantiz
- Lead Developer
- Posts: 2912
- Joined: Wed Jul 25, 2007 2:52 pm
- Location: California
Re: AddSkillBonus
Committed a fix. Would like to point out that the packet that sends skill values takes an int16 so you will not see the decimals in the client.
- John Adams
- Retired
- Posts: 9684
- Joined: Thu Jul 26, 2007 6:27 am
- EQ2Emu Server: EQ2Emulator Test Center
- Characters: John
- Location: Arizona
- Contact:
Re: AddSkillBonus
If the client only displays int16, what's the point of us using floats? Just so our local calcs are more accurate? Also, does this mean if I have a 1.9% stat, it's going to show as "1"? lol
-
Jabantiz
- Lead Developer
- Posts: 2912
- Joined: Wed Jul 25, 2007 2:52 pm
- Location: California
Re: AddSkillBonus
We use floats because live uses them... our calcs will be more accurate now, when we get around to using the skills in equations And yes it will probably show as 1 when it is 1.9John Adams wrote:If the client only displays int16, what's the point of us using floats? Just so our local calcs are more accurate? Also, does this mean if I have a 1.9% stat, it's going to show as "1"? lol
Who is online
Users browsing this forum: No registered users and 1 guest