Groups

EQ2Emulator Development forum.

Moderator: Team Members

Jabantiz
Lead Developer
Posts: 2912
Joined: Wed Jul 25, 2007 2:52 pm
Location: California

Groups

Post by Jabantiz » Sat Oct 24, 2015 2:53 pm

I was forced to do a complete rewrite of groups and just committed the start of it today. The reason for the rewrite is the group code required a client in the vast majority of the code, the issue with this is only players could be in the group, this was not going to work moving forward as we needed support for NPC's in groups (mercs). I tried to hack it in but how heavily the code relied on a client it wasn't going to work, that is why I was forced to do a rewrite.

It should work like it use to but I am sure there is bugs so please report them here. I also identified an element in the character sheet to identify the group leader, can only confirm it in the CoE client though. You can also invite any npc to your group currently, this was just for testing purposes though and will be removed in the future.

Now for the details on the code.
Group code was every where so I decided to add it into its own files, also moved some group code from the player class to the entity class so both players and npcs can be in the group. The major change I made was adding a manager for groups and no changes can be made to the actual group without going through the manager, this should help keep it thread safe. All group code should now be located in PlayerGroups.cpp/.h

User avatar
alfa
Team Member
Posts: 550
Joined: Fri Jul 27, 2007 6:24 pm
Location: France
Contact:

Re: Groups

Post by alfa » Mon Oct 26, 2015 5:03 am

Nice Jab, thanks for the technical explanations
Fight with me... Or die, like the rest.
J.A. say: "I think Xinux tried to tell me this, but I ignore most things he suggests."

DNC
Posts: 6
Joined: Sun Oct 25, 2015 8:07 pm

Re: Groups

Post by DNC » Mon Oct 26, 2015 1:49 pm

Looks great Jabantiz and couldn't agree more that it needed to be done.

I own Terrors of Thulumbra.
No way to get a previous version patched properly in order to assist coding.
If someone is willing to update the login server to a current client, would be appreciated and I could assist on coding.

Have successfully coded swg, neverwinter, star trek, and many other games.

Xinux knows me well and told me to contact someone about updating client version.

PM's are best way to reach me.

Jabantiz
Lead Developer
Posts: 2912
Joined: Wed Jul 25, 2007 2:52 pm
Location: California

Re: Groups

Post by Jabantiz » Tue Oct 27, 2015 9:59 pm

I can see about getting a live client connected but it might be a few days and it won't be perfect.

DNC
Posts: 6
Joined: Sun Oct 25, 2015 8:07 pm

Re: Groups

Post by DNC » Wed Oct 28, 2015 5:25 am

@Jabantiz
I totally understand where you're coming from and appreciate it.
I'll make another backup the moment you do.
:0)

DNC
Posts: 6
Joined: Sun Oct 25, 2015 8:07 pm

Re: Groups

Post by DNC » Wed Oct 28, 2015 5:28 am

If you make a write-up or vid on the exact process required to update the login server, I'll more than happily work on keeping the login server up to date as well.
**Since I can't see my previously submitted msg, I cannot edit it. ;0)

User avatar
Cynnar
Project Leader
Posts: 738
Joined: Sat Sep 27, 2014 1:22 am
EQ2Emu Server: Eq2emulator
Characters: Vlash
Veinlash
Taragak
Cynnar

Re: Groups

Post by Cynnar » Thu Oct 29, 2015 3:30 pm

Jabantiz wrote:I can see about getting a live client connected but it might be a few days and it won't be perfect.
I looked into the opcodes today and if your current range is still at 60127-60129 then it just needs to be bumped up to 60127-60145. This is the latest client as of 10/29/2015. It does have some struct issues, but I was able to log in on my local server.
[ 01000011 01111001 01101110 01101110 01100001 01110010 ]

Follow on:
Twitter Facebook

Contact me:
PM Discord chat email

Hardware: the parts of a computer that can be kicked

DNC
Posts: 6
Joined: Sun Oct 25, 2015 8:07 pm

Re: Groups

Post by DNC » Thu Oct 29, 2015 4:14 pm

Cynnar wrote:
Jabantiz wrote:I can see about getting a live client connected but it might be a few days and it won't be perfect.
I looked into the opcodes today and if your current range is still at 60127-60129 then it just needs to be bumped up to 60127-60145. This is the latest client as of 10/29/2015. It does have some struct issues, but I was able to log in on my local server.
My current client version info:
CL 653473 Build 12261L

User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

Re: Groups

Post by John Adams » Thu Oct 29, 2015 9:09 pm

DNC wrote:If you make a write-up or vid on the exact process required to update the login server, I'll more than happily work on keeping the login server up to date as well.
LoginServer is not open source, no one changes it but me or Jabantiz. The only thing Login needs are opcode bumps, and those rarely change. It's the WorldStructs that require the major changes for client compatibility.

Yes, I'm still around ;)

DNC
Posts: 6
Joined: Sun Oct 25, 2015 8:07 pm

Re: Groups

Post by DNC » Thu Oct 29, 2015 9:16 pm

John Adams wrote:
DNC wrote:If you make a write-up or vid on the exact process required to update the login server, I'll more than happily work on keeping the login server up to date as well.
LoginServer is not open source, no one changes it but me or Jabantiz. The only thing Login needs are opcode bumps, and those rarely change. It's the WorldStructs that require the major changes for client compatibility.

Yes, I'm still around ;)

LOL
I know you're still around. Otherwise you wouldn't be moving those servers around. ;0)
I also know I still have files that I have never released and just thought I could be of assistance.
Past is the past.
Anyhow, glad to see you're still here and things are looking good.
Last edited by DNC on Thu Oct 29, 2015 10:01 pm, edited 1 time in total.

User avatar
Cynnar
Project Leader
Posts: 738
Joined: Sat Sep 27, 2014 1:22 am
EQ2Emu Server: Eq2emulator
Characters: Vlash
Veinlash
Taragak
Cynnar

Re: Groups

Post by Cynnar » Thu Oct 29, 2015 9:33 pm

DNC wrote:My current client version info:
CL 653473 Build 12261L
Yeah this is the current live client. So this will be a safe one to backup I think. The info about the opcode range was aimed at Jab, and I thought I had put that in the post. My bad. :oops:
[ 01000011 01111001 01101110 01101110 01100001 01110010 ]

Follow on:
Twitter Facebook

Contact me:
PM Discord chat email

Hardware: the parts of a computer that can be kicked

Jabantiz
Lead Developer
Posts: 2912
Joined: Wed Jul 25, 2007 2:52 pm
Location: California

Re: Groups

Post by Jabantiz » Thu Oct 29, 2015 10:30 pm

The version range Cynnar was referring to is the data version range, it is hidden in the packets and not displayed any where else but is essential. Also the version range bump that he suggested does work so the current live client will work soon, there was an error in the update process though that I need to talk to John about, as soon as that is resolved the client will work so feel free to make a backup of it.

User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

Re: Groups

Post by John Adams » Thu Oct 29, 2015 11:00 pm

Give it another go.

Jabantiz
Lead Developer
Posts: 2912
Joined: Wed Jul 25, 2007 2:52 pm
Location: California

Re: Groups

Post by Jabantiz » Fri Oct 30, 2015 10:09 pm

Everything is now updated and the client can log in, currently sitting on the emu server with the live client.

Thanks Cynnar and John.

User avatar
Cynnar
Project Leader
Posts: 738
Joined: Sat Sep 27, 2014 1:22 am
EQ2Emu Server: Eq2emulator
Characters: Vlash
Veinlash
Taragak
Cynnar

Re: Groups

Post by Cynnar » Fri Oct 30, 2015 10:17 pm

Jabantiz wrote:Everything is now updated and the client can log in, currently sitting on the emu server with the live client.

Thanks Cynnar and John.
No No! Thank you my good man. :)

I will let FB world know tomorrow.
[ 01000011 01111001 01101110 01101110 01100001 01110010 ]

Follow on:
Twitter Facebook

Contact me:
PM Discord chat email

Hardware: the parts of a computer that can be kicked

Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests