Scribing

[Gangrenous]

Hey Jab does scribing work? It does not really have to be Master, Adept, etc. I just need to know if you can have an item scribe a spell.

[Jabantiz]

Yes it does. The item type needs to be set "Scroll" and then in the `item_details_skill` table you put in the item id and the spell id/tier you want the item to scribe.

[Gangrenous]

You are a gentlemen and a scholar.

[Gangrenous]

I tried this just now and it worked beautifully. So at this point I can start adding original EQ1 merchants for spells, etc and get the spell scrolls aligned with the actual spell. Brilliant.

[Gangrenous]

I am going to add a way in the editor to manipulate these. Would there ever be an instance where multiple spells are attached to one item? If not then I see no reason in having these in a list or grid, it could be accomplished on the main form.

Doing a quick query, I am not seeing even one record out of 25,117 that has the same item entry.

Code: Select all

SELECT address, count(id) as cnt FROM list
GROUP BY address HAVING cnt > 1;

[Jabantiz]

There should never be more then 1 spell per item, client can't handle that.

The tables are set up this way to match the item structs. Item types use a different packet structure from each other so all the `item_details` tables are the data that only that specific item type needs.

[Gangrenous]

Oh okay, makes sense.

[Gangrenous]

Jabantiz are there other things that can cause these to not show the right click scribe? I had to redo my spells and the option is now gone again. What about tier restrictions? I absolutely have the spells set for "scroll" and there are tons of entries in item_details_skill that are tying the item_id to the spell_id, I have them currently for tier 1. The spells are enabled, they do have scripts and I meet the class and level restrictions, which are all level 1 for testing.

[Gangrenous]

Funny how this happens, spent hours on it and 2 minutes after I post I get a positive result.....nm.

[Gangrenous]

Hmm, well this is still a mystery if you are available to assist. I have one spell that is showing scribe, none of the others are. I have compared the items and the spells and cannot see any different in the entries.

[Gangrenous]

Okay I figured out what is causing the issue, but it does not make sense. In spell_classes, the level column.

I have an entry for a spell, with an adventure class of 29, which is conjurer and the level being level 4. My character is level 29 but cannot scribe it unless I set that level at 1 in the spell_classes table and log out and back in.

[Gangrenous]

After reporting back on some logging.....these levels are x10? Since when? I did not know this. I put some debug logging into ScribeAllowed and noticed that the spell levels for the spells are x10

[Gangrenous]

Pretty sure ScribeAllowed should look like this.

Code: Select all

bool Spell::ScribeAllowed(Player* player){
	bool ret = false;
	if(player){
		MSpellInfo.lock();
		for(int32 i=0;!ret && i<levels.size();i++){
			if((player->GetAdventureClass() == levels[i]->adventure_class || player->GetTradeskillClass() == levels[i]->tradeskill_class) && player->GetLevel() >= (levels[i]->spell_level/10))
				ret = true;
		}
		MSpellInfo.unlock();
	}
	return ret;
}

[Jabantiz]

Some levels have to be x10 because that is what the packets require, I have no clue why it is set up like that and others are set up to be normal but that is the way SoR/DBG works...

[Gangrenous]

What about getting that fix added to official? It is working for me.