Highlighting off by 1 if line is greater then 10000

Bug forum for In-House and 3rd-Party tools.

Moderator: Team Members

Forum rules
READ THE STICKY ON PROPER BUG SUBMISSION FORMAT BEFORE POSTING.
Post Reply
User avatar
xinux
Team Member
Posts: 680
Joined: Wed Mar 10, 2010 11:10 am
Location: Destroyer of Servers

Highlighting off by 1 if line is greater then 10000

Post by xinux » Fri Nov 22, 2013 2:03 pm

Highlighting get's off by one when the line number is greater then 10000. Would it be possiable to add a if statement in the following section so it changes the offset by 1 or use a new map if the line number is 10000 or greater?

SelectionData.cs

Code: Select all

	public class SelectionData {
		//we store the offsets for data offsets per byte. so each line would have 16 possible offsets.
		//well, since each byte is actually 2 ASCII characters and a space, we need to map it differently
		//so actually each selection offset is spaced 3 bytes apart
		//eg. offset 0 is actually at offset 6   ->  SelectionOffsetMapping[0] = 6   ->  0000:	0
		//eg. offset 5 is actually at offset 21  ->  SelectionOffsetMapping[5] = 21  ->  0000:	01 FF CE 01 00 0)
		public static int[] SelectionOffsetMapping = new int[] {
			6,  9,  12, 15,
			18, 21, 24, 27,
			30, 33, 36, 39,
			42, 45, 48, 51
		};
EQ II - Build=1360 (Orig) - Build=1360 (DoF) - Build=2654 (KoS) - Build=3375 (Classic) - Build=3554 (EoF)
EQ II - Build=4412 (RoK) - Build=5122 (TSO) - Build=6118 (SF) - Build=7628 (DoV) - Build=8295 (Aod)

User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

Re: Highlighting off by 1 if line is greater then 10000

Post by John Adams » Fri Nov 22, 2013 2:12 pm

You mean THIS? :)

Sure, go ahead and fix it. You should have rights to commit to EQ2Tools.

User avatar
xinux
Team Member
Posts: 680
Joined: Wed Mar 10, 2010 11:10 am
Location: Destroyer of Servers

Re: Highlighting off by 1 if line is greater then 10000

Post by xinux » Fri Nov 22, 2013 3:32 pm

Been playing with it but haven't got it to work right yet
EQ II - Build=1360 (Orig) - Build=1360 (DoF) - Build=2654 (KoS) - Build=3375 (Classic) - Build=3554 (EoF)
EQ II - Build=4412 (RoK) - Build=5122 (TSO) - Build=6118 (SF) - Build=7628 (DoV) - Build=8295 (Aod)

User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

Re: Highlighting off by 1 if line is greater then 10000

Post by John Adams » Fri Nov 22, 2013 3:37 pm

Yup, I failed after staring at it a week and Scatman disappears usually for 6 mos when I mention C-sharp :mrgreen:

User avatar
Cynnar
Project Leader
Posts: 738
Joined: Sat Sep 27, 2014 1:22 am
EQ2Emu Server: Eq2emulator
Characters: Vlash
Veinlash
Taragak
Cynnar

Re: Highlighting off by 1 if line is greater then 10000

Post by Cynnar » Wed Jul 26, 2017 9:57 pm

Checking to see if this can be archived.
It's a keeper.
[ 01000011 01111001 01101110 01101110 01100001 01110010 ]

Follow on:
Twitter Facebook

Contact me:
PM Discord chat email

Hardware: the parts of a computer that can be kicked

Jabantiz
Lead Developer
Posts: 2912
Joined: Wed Jul 25, 2007 2:52 pm
Location: California

Re: Highlighting off by 1 if line is greater then 10000

Post by Jabantiz » Wed Jul 26, 2017 10:21 pm

I think this one might still be an issue.

User avatar
Ememjr
Team Member
Posts: 975
Joined: Wed Mar 15, 2017 9:41 am
EQ2Emu Server: Perseverance

Re: Highlighting off by 1 if line is greater then 10000

Post by Ememjr » Thu Jul 27, 2017 7:50 am

offset.JPG
confirmed This is still an issue
You do not have the required permissions to view the files attached to this post.

User avatar
Cynnar
Project Leader
Posts: 738
Joined: Sat Sep 27, 2014 1:22 am
EQ2Emu Server: Eq2emulator
Characters: Vlash
Veinlash
Taragak
Cynnar

Re: Highlighting off by 1 if line is greater then 10000

Post by Cynnar » Thu Jul 27, 2017 7:59 am

Roger that.
[ 01000011 01111001 01101110 01101110 01100001 01110010 ]

Follow on:
Twitter Facebook

Contact me:
PM Discord chat email

Hardware: the parts of a computer that can be kicked

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest