worldstruct.xml cleanup

[Ememjr]

I have notice many instances in the worldstruct.xml where a struct is duplicated for a new data version but the struct it self never changed

is it safe to delete the duplicates for example, these seem to be exactly the same, can the one with 57048 be removed

this is just 2 of the hundreds of dupes, and i will go through and clean up , at 27k lines its getting to be a mess to find things

Code: Select all

<Struct Name="WS_ChatFiltersMsg" ClientVersion="1" OpcodeName="OP_ChatFiltersMsg">
<Data ElementName="unknown1" Type="int16" Size="1" />
<Data ElementName="Game_Chat_Text" Type="int16" Size="1" />
<Data ElementName="Chat_Text" Type="int16" Size="1" />
<Data ElementName="Character_Text" Type="int16" Size="1" />
<Data ElementName="Spells_Combat" Type="int16" Size="1" />
<Data ElementName="Spells_Combat2" Type="int16" Size="1" />
<Data ElementName="Combat_Other_Command" Type="int16" Size="1" />
<Data ElementName="Merchant_Consider_Trade_Voice" Type="int16" Size="1" />
</Struct>

Code: Select all

<Struct Name="WS_ChatFiltersMsg" ClientVersion="57048" OpcodeName="OP_ChatFiltersMsg">
<Data ElementName="unknown1" Type="int16" Size="1" />
<Data ElementName="Game_Chat_Text" Type="int16" Size="1" />
<Data ElementName="Chat_Text" Type="int16" Size="1" />
<Data ElementName="Character_Text" Type="int16" Size="1" />
<Data ElementName="Spells_Combat" Type="int16" Size="1" />
<Data ElementName="Spells_Combat2" Type="int16" Size="1" />
<Data ElementName="Combat_Other_Command" Type="int16" Size="1" />
<Data ElementName="Merchant_Consider_Trade_Voice" Type="int16" Size="1" />

and here there are 3 the but the middle one is 57048 is the same a 1, but 57080 is different and needs to stay

Code: Select all

<Struct Name="WS_CharacterMounts" ClientVersion="1" OpcodeName="OP_CharacterMounts">
	<Data ElementName="num_mount" Type="int16" />
	<Data ElementName="mount_array" Type="Array" ArraySizeVariable="num_mount">
	<Data ElementName="unique_id" Type="int32" />
	<Data ElementName="unknown1" Type="int16" />
	<Data ElementName="index" Type="int8" />
	<Data ElementName="unknown2" Type="int16" />
	<Data ElementName="unknown3" Type="int16" />
	<Data ElementName="unknown4" Type="int16" />
	<Data ElementName="unknown5" Type="int8" />
</Data>	
</Struct>

Code: Select all

<Struct Name="WS_CharacterMounts" ClientVersion="57048" OpcodeName="OP_CharacterMounts">
	<Data ElementName="num_mount" Type="int16" />
	<Data ElementName="mount_array" Type="Array" ArraySizeVariable="num_mount">
	<Data ElementName="unique_id" Type="int32" />
	<Data ElementName="unknown1" Type="int16" />
	<Data ElementName="index" Type="int8" />
	<Data ElementName="unknown2" Type="int16" />
	<Data ElementName="unknown3" Type="int16" />
	<Data ElementName="unknown4" Type="int16" />
	<Data ElementName="unknown5" Type="int8" />
</Data>	
</Struct>

Code: Select all

<Struct Name="WS_CharacterMounts" ClientVersion="57080" OpcodeName="OP_CharacterMounts">
	<Data ElementName="num_mount" Type="int16" />
	<Data ElementName="mount_array" Type="Array" ArraySizeVariable="num_mount">
	<Data ElementName="unique_id" Type="int32" />
	<Data ElementName="unknown1" Type="int32" />
	<Data ElementName="index" Type="int8" />
	<Data ElementName="unknown2" Type="int16" />
	<Data ElementName="unknown3" Type="int16" />
	<Data ElementName="unknown4" Type="int16" />
	<Data ElementName="unknown5" Type="int8" />
</Data>	
</Struct>

[Jabantiz]

Dupes can be deleted as long as they don't contain a substruct or they aren't used as a substruct.