Commands.cpp

[Gangrenous]

Around line 2648 in commands.cpp

Code: Select all

if (collection = player->GetPendingCollectionReward())

Probably should be a comparison instead of an assignment

[Jabantiz]

This one is actually correct how it is, basically it is assigning to the variable (pointer) and then checking if the pointer is valid.

It is the same as doing this

Code: Select all

collection = player->GetPendingCollectionReward();
if (collection)

[Gangrenous]

My compiler was complaining about it. I may write it differently.

[tyrbo]

Weird that your compiler would complain about that.
Error or warning?

Maybe it thinks you meant to do == and is trying to protect you from a silly bug.

[Gangrenous]

Warning.