Passive spells and addspellbonus\addskillbonus

[Ememjr]

working with the AA as i have found out most of them are passive spells
so for the first test spell
i have as the lua script

Code: Select all

function cast(Caster, Target,BonusAmt)
    AddSpellBonus(Caster,1,BonusAmt)
    AddSpellBonus(Caster,4,BonusAmt)
    AddSkillBonus(Caster,2638198038,BonusAmt)
    --AddSpellBookEntry(Caster,1002739,newtier)
	
end

BonusAmt is 4,8,12,16,20,24,28,32,36,40 for tiers 1-10
when i click the AA and get tier 1 my STA and INT increase by 4 as expected
but focus(skill) is going from 10/100 to 18/104. should be 14/104
-- John Adams had this same issue in this post viewtopic.php?f=3&t=3085&hilit=passive (5th post)
I could not tell if that was corrected in following posts(i guess not)

the other issue is the bonuses are not persisting through zoning, or logging in as a passive spell should do.

if i then click the AA again to go to tier 2 should be an 8 increase total the sta and int do increase by 4 as expected
but the focus no longer updates

Jab, know you were the creator of the Passive spells do you think you could take a look

thnaks

[Jabantiz]

I knew next to nothing about the spell system when I attempted that...

Really the only thing I did was bypass the casting method and have it apply when it is added to the spell book or loaded in to a zone. They also did persist through zones and logging back then. I do not think there was any support to remove a passive and apply a better one in its place though.

Overall I think passives need to be redone completely to add a more appropriate system instead of the hack job I did back then just to get them to work.