AA's and Traits

[Ememjr]

I am finally at a point where AA changes and Traits changes can be implemented

There is some DB changes that need to be made as well as some data to be updated

the changes should be firm, as they are working on my side

the data on the otherhand will be enough data to see functionality of these systems

i will post additional data to be imported or reimported as it becomes available

this first one is table spell_traits, this includes a altertable and data for wizard/half elf,

spell_traits.txt

be sure to change the DB name

i will post more in this thread soon, once these DB changes are published I will commit my code changes

[Ememjr]

this one is for AA, i am sending these with data because i cannot see the data is being exported in the dumps, so i will assume they are empty

[Rixan]

Thank you so much for this. BTW, I think you missed spell_aa table or does that not do anything?

[Ememjr]

spell_aa is not used nor needed, i think at one time they were thinking about spliting up spells, traits and AA
but i am glad they didnt, becuase everything is a spell anyway

[John Adams]

These tables are all committed to patchserver, including the drop of the old `spells_aa`. Testing it out, if my server doesn't explode I will commit the version bump (minor version 37) and data.

Update:
`classification` appears to be missing from your SQL for spells_aa_nodelist.

Error:

Code: Select all

12:08:21 I AA        : Loading Alternate Advancements...
12:08:21 E DBCore    : #1054: Unknown column 'classification' in 'field list'
Query:
SELECT `nodeid`, snl.spellcrc, `name`, `description`, snl.aa_list_fk, snl.icon_id, snl.icon_backdrop, `xcoord`, `ycoord`, `pointspertier`, `maxtier`, `firstparentid`, `firstparentrequiredtier`, `classification`, `classificationpointsrequired`, `pointsspentintreetounlock`, `title` FROM spell_aa_nodelist snl
12:08:21 I AA        : Loaded 0 Alternate Advancement(s)
1

Your SQL:

Code: Select all

DROP TABLE IF EXISTS `spell_aa_nodelist`;

CREATE TABLE `spell_aa_nodelist` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `aa_list_fk` int(10) unsigned NOT NULL DEFAULT '0',
  `displayedclassification` varchar(64) NOT NULL DEFAULT '',
  `requiredclassification` varchar(64) NOT NULL DEFAULT '',
  `classificationpointsrequired` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `description` text,
  `firstparentid` int(10) unsigned NOT NULL DEFAULT '0',
  `firstparentrequiredtier` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `maxtier` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `minlevel` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `name` varchar(64) NOT NULL DEFAULT '',
  `nodeid` int(10) unsigned NOT NULL DEFAULT '0',
  `pointspertier` smallint(5) unsigned NOT NULL DEFAULT '0',
  `pointsspentgloballytounlock` smallint(5) unsigned NOT NULL DEFAULT '0',
  `pointsspentintreetounlock` smallint(5) unsigned NOT NULL DEFAULT '0',
  `spellcrc` int(10) unsigned NOT NULL DEFAULT '0',
  `title` varchar(64) NOT NULL DEFAULT '',
  `titlelevel` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `xcoord` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `ycoord` tinyint(3) unsigned NOT NULL DEFAULT '0',
  `icon_backdrop` int(10) DEFAULT '0',
  `icon_id` int(10) DEFAULT '0',
  PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=3085 DEFAULT CHARSET=latin1;

[Rixan]

I worked around by renaming classification to displayedclassification and added requiredclassification in the Stitch PVP dev database.

Copying the data seemed fine afterward.

edit: also [mention]John Adams[/mention], you would need the updated structs for AA too for the database changes to work and I'm still waiting on that from EmemJR.

[John Adams]

Ahh, right. Ok, then it is not ready for implementation.

I'll leave the tables in place, once [mention]Ememjr[/mention] commits the structs, I will attempt to test again.

[Ememjr]

getting ready to commit now my changes now, there will be alot even some new stuff that hopefully does break things

commits and db updates sometime get wonky for the reason i want db updated first, but then when db gets updated the commit needs almost immediate

[John Adams]

I understand. But keep in mind, the patcher won't patch a world until you tell it to (minor version) so you should be able to commit all code and tables just fine, and leave version.h where it is until you test.

The one thing I am not confident about is "data updates". I can't remember if we fixed that in the new patcher.

[mention]Ememjr[/mention] Go ahead and update your server to minor version 37, recompile and see if you get the tables and the code runs without error. I have all your table updates and data updates applied to PatchServer. If all goes well, you can commit version.h as version 37.

[Ememjr]

I have committed, and should include the change to not look for classification, and look for those other 2


If i update version.h will that wipe any of my data i server still shows, version 28

[Ememjr]

also it would be very nice if we could somehow get access to all the version updates , aside from the server trying to patch
something like where we can go into the quest changelog and see all the data changes have a changelog we can view prior to installing updates automatically,
nothing worse than a table getting drop and readded with data and it overs the local data

[John Adams]

There is no way to "cherry pick" updates. The best way to avoid losing your work is to keep a backup before updating from patcher. I usually had a Dev DB I work(ed) on, but tested only on my Test DB. If changes worked, I updated Dev DB before continuing work on next phase.

(btw, when I say "no way" I mean no way >today<. Anyone is welcome to create a better process)

[Ememjr]

dont really want to cherry pick them just want to be able to review them either before or after they are installed so we know what has changed

everyonce in a while i get to see eq2-updates.sql but it seems to disappear often

[tyrbo]

dont really want to cherry pick them just want to be able to review them either before or after they are installed so we know what has changed

everyonce in a while i get to see eq2-updates.sql but it seems to disappear often

You should be able to jump in the code and modify it to pull down the update file and keep it around if you want.
I've had to do that a few times before to safely merge in changes when I was still keeping up to date with those.

[Cynnar]

Also you can log it. Can't remember off the top of my head which one it is that turns it on, but it can be logged which gives you the SQL queries I believe.