BUG:Deleting item from bag

[Ememjr]

this bug was reported by Gangrenous, on discord

just noticed if you delete an item from within a bag, the item still shows in the bag description. You can fix it by dragging another item into the bag, but still an issue that needs fixing.
It does not do it if you move an item out of the bag, only if you destroy the item from within the bag

[Ememjr]

looked into this, the destroy command does not seem to be sending a SendBagUpdate() command to update the bag info
whereas move and add inventory does

[Ememjr]

this has been fixed and commited , added code to the destroy command to update the bag

Code: Select all

int32 bag_id = item->details.inv_slot_id; // this lined added for detroy item not updateing bag list
                database.DeleteItem(client->GetCharacterID(), item, 0);
                client->GetPlayer()->item_list.DestroyItem(index);
                EQ2Packet* outapp = client->GetPlayer()->SendInventoryUpdate(client->GetVersion());
                client->QueuePacket(outapp);

                outapp = client->GetPlayer()->SendBagUpdate(bag_id, client->GetVersion());// this lined added for detroy item not updateing bag list

                if (outapp)// this lined added for detroy item not updateing bag list
                    client->QueuePacket(outapp);// this lined added for detroy item not updateing bag list

this will b in commands.cpp
void Commands::Command_Inventory

committed to SVN Rev # 2827

[Gangrenous]

Did you push your change? I am only seeing up to Revision 2824

[Gangrenous]

Capture.PNG

[Jabantiz]

Dev svn syncs with public svn every mon (maybe sun night)

[Gangrenous]

That, I did not know.