World server crash bug

Post in this forum if you found any bugs with server functionality.

Moderator: Team Members

Forum rules
READ THE STICKY ON PROPER BUG SUBMISSION FORMAT BEFORE POSTING.
Post Reply
Cadimiom
Team: Zombie
Posts: 74
Joined: Wed Jul 25, 2007 2:31 pm

World server crash bug

Post by Cadimiom » Wed Mar 04, 2020 5:43 am

There was an issue with out of order packets (sequencing code in EQStream) that caused an infinite loop and crashed if you were in a zone for too long...:

[204.204.204.204:52428->204.204.204.204:52428] [Seq=0] [OpCode 0x0009 (OP_Unknow
n) Size=16]

eg. that seq number would go up to the uint16 cap then crash.

This fixes us to not indefinitely keep sequencing the same packet over and over (preventing said crash):
http://cutpon.com:3000/devn00b/EQ2EMu/c ... cb9caec3c0

Edit: To note there are some eqemu log calls commented out in the new functions. I was hoping at a later time to revisit EQStream to touch up some other things. But this was crashing the entire world server when the client did this so seemed important to push out (least in my git for the team we have).

Jabantiz
Lead Developer
Posts: 2912
Joined: Wed Jul 25, 2007 2:52 pm
Location: California

Re: World server crash bug

Post by Jabantiz » Wed Mar 04, 2020 4:59 pm

Thanks for the fix, it is committed to dev svn and will be up on the emu server soon.

Side note, is is nice to see code actually coming back to the project for a change so thank you for this.

User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

Re: World server crash bug

Post by John Adams » Mon Mar 16, 2020 6:02 pm

Cadimiom wrote: Wed Mar 04, 2020 5:43 am [204.204.204.204:52428->204.204.204.204:52428] [Seq=0] [OpCode 0x0009 (OP_Unknow
n) Size=16]

eg. that seq number would go up to the uint16 cap then crash.

This fixes us to not indefinitely keep sequencing the same packet over and over (preventing said crash):
How the heck do you remember this stuff from 15 YEARS ago? After 10 years, I retired from this in 2016, and can barely remember the domain name :mrgreen:

Cadimiom
Team: Zombie
Posts: 74
Joined: Wed Jul 25, 2007 2:31 pm

Re: World server crash bug

Post by Cadimiom » Tue Mar 17, 2020 1:20 pm

John Adams wrote: Mon Mar 16, 2020 6:02 pm
Cadimiom wrote: Wed Mar 04, 2020 5:43 am [204.204.204.204:52428->204.204.204.204:52428] [Seq=0] [OpCode 0x0009 (OP_Unknow
n) Size=16]

eg. that seq number would go up to the uint16 cap then crash.

This fixes us to not indefinitely keep sequencing the same packet over and over (preventing said crash):
How the heck do you remember this stuff from 15 YEARS ago? After 10 years, I retired from this in 2016, and can barely remember the domain name :mrgreen:
Probably cause these are the only things I remember lol.. I forget plenty of other stuff.

You can thank devn00b for deciding to delve in eq2emu and plan to host a pvp server on www.zeklabs.com cause otherwise I wouldn't have probably been involved as I don't like doing emulation projects solo.

Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests