Merchants

[Scatman]

You? spare time? come on now!

[LethalEncounter]

Hey John, if you get a second could you put this on your server and see if you have any problems getting it working? It is not 100% done yet as the buybuck items are listing correctly, but for whatever reason the client doesnt send anything when you click buy. Please let me know if you have any problems.

[John Adams]

I can actually buy just fine. I had to change the command_text back to "frommerchant" though, from "Buy from merchant". Not sure why it should care what the display text is, but at least it is working.

There is a little visual oddity though with the merchant list:

merchant(qty).jpg

Also note, the Buy Stack does seem to work, but the display in player inventory doesn't seem to show (10), if it is supposed to. I cannot remember. But when I Sell Stack, it shows the quantity fine.

[John Adams]

Btw, Sell works too. Lots of chatter in the server console tho when these actions are taking place, but I figure you are debugging
Looks good though, man. Nice job. I'll leave Tess up for you guys to try the merchant (Hanna Deeppockets)
Btw, all scripts are disabled. Don't even bother trying quests

[LethalEncounter]

Oh yah the only thing that shouldn't work right now is buyback and I am fixing that right now. Buy and sell should work correctly. I'm not sure what that * means. Items in general need a lot of work though.

[John Adams]

Yah these are the old items with 1/2 the data in place, so I am not worried. I changed the qty of items sold, and that little * didn't change. I thought maybe it was supposed to show qty in stock, but I guess not.
PS: I thought by your statement you meant that the client (in general) sent nothing when you clicked Buy hah. but in re-reading, you meant just the buy-back tab

[LethalEncounter]

Yah the problem was our old list of commands. The client didn't send the command because the world server told it that the command wasn't valid. I updated that and the other 100 or so commands they added in the past 2 years

[LethalEncounter]

OK, I am uploading a new version. This fixes all of the merchant issues that I know about. BTW the * meant that the item was stackable. I have since added a field in the items table that allows you to specify which items are stackable and how high. Buyback should work properly. If you find any errors at all please let me know. It should work perfectly now.

[Scatman]

You da man! I haven't had time to get on because I've got company over but they should be gone soon and then I'll hop on and test her out.

[Scatman]

There are a few things that aren't exactly like live and I logged on there to verify my findings with some screen shots. We basically have two scenarios, merchants and brokers and I'm not sure if you've even taken into account brokers yet but I'll post it anyway for future reference.

So it turns if an item has an asterix, then that means it is stackable. If an item does not have an asterix, then it is not stackable. This is shown in screen shots 1, 2, and 3.
If an item is indeed stackable, then all three buttons will be present. The "Buy x (stack)" button shows the MAX stack size for that item. So in screen shot one, the max number of dough that can be stacked is 200 (harvestables are like this now). In screen shot 2, the max number of dried bread that can be stacked is 20.
In screen shot 3, a torch is not stackable showing this by no asterix and the "Buy x (stack)" and "Buy Quantity" buttons are not shown.
Remember that merchants have unlimited number of supplies meaning they cannot run out of items being sold. Now there is a time when the asterix can be a number.

Here we have the broker window. The number where the asterix would normally be shows the amount of that item the player is selling. So Klubbernight is selling 400 lion meat and you cannot buy more than 400 from him.

[Zcoretri]

You can only buy to what the Max stack is also, so in the case of your post there, you can buy 200 at a time, but say you already had a stack of 50 in your inventory, your first purchase will be 150, then subsequent purchases will be 200.

[Scatman]

Oh right good point! That goes for both broker window and merchant.

[John Adams]

Player inventory window should open when you activate a merchant, like the bank (I think).

[LethalEncounter]

So it turns if an item has an asterix, then that means it is stackable. If an item does not have an asterix, then it is not stackable. This is shown in screen shots 1, 2, and 3.
If an item is indeed stackable, then all three buttons will be present. The "Buy x (stack)" button shows the MAX stack size for that item. So in screen shot one, the max number of dough that can be stacked is 200 (harvestables are like this now). In screen shot 2, the max number of dried bread that can be stacked is 20.
In screen shot 3, a torch is not stackable showing this by no asterix and the "Buy x (stack)" and "Buy Quantity" buttons are not shown.
Remember that merchants have unlimited number of supplies meaning they cannot run out of items being sold. Now there is a time when the asterix can be a number.

Yah, I havent messed with brokers yet. However, stackable items already work. Change the stack_count field in the items table to the max stack size for that item and it will enable the other 2 buttons. There might be certain cases where you want the NPC to run out of an item and the Emu allows this, however if you leave the quantity in the merchants table the default of 65535 they will never run out.
In short, the above problems are only configuration items and not actual problems. The only thing I need to fix is like Zcoretri mentioned about the stack size limited by existing items. I'm not sure about the inventory window opening though.

[Scatman]

Sounds good!