Items Validation

[John Adams]

Bion (or any team member),

Can I please get someone to look into these odd item appearances? I am pretty certain that each item with an appearance should only have ONE appearance... but there's a few items that have 2 appearance records.

Code: Select all

29816 
29817 
46527 
46528 
46824 
46825 
47047 
47048

Can we determine which item_appearance.id needs to be deleted? The Items Editor should be available to perform this task. If not, you can just let me know the IDs (item_appearance.id, not item_id) and I will delete them here.

Thanks,
Jc

[Bion]

Ok john i determined the correct look for these items checking them with live. most are the same appearance id just different colors but a couple had a total new appearance. this differences even though they have the same name is not surprising due to the fact this are player craftable weapons that has changed a few times . something to note is that anything equipment that is the start of a tier 10,20 etc that lvl craftable is the old style and is mastercrafted the ones that has lvls like 22,32 etc are the new type and treasured although there was a period that it showed as mastercrafted too.. it is kinda confusing since it changed a few times and i am not really sure how it is now as i think it has changed yet again since i crafted.

[John Adams]

Thanks, Bion. I didn't understand 1/2 of that, but if you think those few items could lose an appearance, let's delete the bad/non-current one.

Also if you would, can you eyeball this list of Items? Run this query on my DB:

Code: Select all

select count(*), items.id,items.name from items group by name having count(id) > 1;

Look up any of those items in the item editor, and you will see 2 of them listed - usually different tiers. Not sure what these different tiers mean for an item with the same name/id.

A different type of example would be the Dwarven Work Boots. This item is duplicated, but has 2 unique SOE_ID's, different weight, but I think mostly the rest is the same. My thought on this is one comes from a much older Items log, or is as you say an original version item no longer used. What should we do with these? There's about 1,700 or so.

Thanks!

[Bion]

I have already taken care of deleting those extra appearances we needed to get rid of them due to it will always use the first one found and the second one will never be used. and of course the items would not beable to take the second appearance if it was suppose to have it so that is taken care of.

i ran that command on your server bear with me on this I dont know much about sql really.

at first it looks as if these items have the same id number most of them twice but that don't make sense i thought a record has to have a distinct number? if i look at the items table using the id of the item from that query i only see one record.

I did look at them in the item editor which is quite nice btw it does show me 2 items but that is because it is looking it up by name and there are tons of items in eq2 which have the same name but a different soe_id because it is a different item.
like the work boots you mentioned that is a heritage quest reward that is the same name but different for every armor type there is a cloth,plate,leather version of it but it also has different stats i think depending on it too not 100% been awhile since i seen that item in game. not only that but it also has a different item for it because you can place it in the house and some of those types of items have the same name others have Trophy:itemname.

The first few items in that query have the same name but are 2 different items one is the incomplete version of the book and the second one is the completed version. all of these have different soe_ids looking at them with the item editor.

Trash loot can have the same name but will also have different soe_ids because depending on the lvl of the mob the body drop. bat fur , gnoll fang etc will be worth more the higher the lvl also there are rare body drops that are worth more then the normal ones they also can have the same name but will be labled fabled

[John Adams]

Perfect, I think you have answered my question then. They have unique IDs because they are indeed unique in one fashion or another. I know that some items can have a trophy item for your house... so maybe that's what I am seeing.

We'll just go through Items slowly, and if anything looks like a dupe, we can take care of it then I guess. Thanks for taking the time to look into these things. I appreciate it.

[Bion]

Not a problem i am happy to help. ya all the items i looked at were indeed unique.

There are some items we could get rid of but really i vote we keep them unless we don't have all the data or something like that for them. That is the old player craftable items i know sony don't use these anymore however it would help the few server admins out there that want to try to recreate the launch feel.

I have uploaded another 2 logs of items should be a little over a k

[LethalEncounter]

I couldn't find the original post about the problem, but if you notice item appearances not being sent correctly DONT try to fix them yourself. The reason being that I had the green and blue swapped in one instance that was causing things to look pink. Whenever I check in the change it should fix most (all?) of them.

[John Adams]

Awesome LE. Thank you for the heads up. I was talking to a player the other day online and he reported his armor "looked funny", but when he switched it to High Quality gfx, he said it looked ok. Something else for us to consider when validating items.