Implementing: Procs

[John Adams]

Nice. Exciting

[Jabantiz]

Implemented most of the proc types, we have no code for block however so can't implement that yet. Need clarification on heal and beneficial though, are they when an entity casts or the spell lands on them, or do we want both. Also will heal trigger a beneficial proc?

[Jabantiz]

Committed all my code for procs, only block, heal, and beneficial procs haven't been implemented yet, waiting for clarification on heal and beneficial and we have no code for blocking yet so can't add that either.

[thefoof]

A heal and buffs count as beneficial, but a buff doesn't count as a heal, hope that helps , also I don't know if there are any procs like this that proc on being the target of the spell, I think only the caster but I could be wrong.

[Jabantiz]

Added beneficial and heal procs, didn't test all possible proc types so keep an eye out for errors.

[John Adams]

Cool, so (unless I missed it) what tells the code there is a Proc? Just the fact the function proc() exists in a script? Or did we add a flag to the spells/items tables?

[Jabantiz]

You need to use AddProc to register the proc on a spawn and RemoveProc to remove the proc

Here is my test item script I assigned to an item one of my chars already had

Code: Select all

function equipped(Item, Player)
   AddProc(Player, 1, 50, Item)
   Say(Player, "Equipped")
end

function unequipped(Item, Player)
   RemoveProc(Player, Item)
   Say(Player, "UnEquiped")
end

function proc(Item, Caster, Target, Type)
   Say(Caster, "Proc type: " .. Type)
end

When the item is equipped the player will do a Say() and add the proc, when unequipped the player will do a Say() and remove the proc, when a proc actually goes off the player will just do a Say()

[John Adams]

I should have asked more specifically about Spells, since I am not doing anything with Items at this time.

Remember, I am assuming a Spell Proc is one of the sub-spells that I'm trying to avoid creating

[Jabantiz]

Basically the same thing

Code: Select all

function cast(Caster, Target)
    AddProc(Target, 1, 8.5) -- 8.5% chance to proc an offensive (1) spell
end

function proc(Caster, Target, Type)
    -- proc code here
end

function remove(Caster, Target)
    RemoveProc(Target)
end

no need for another spell, it is possible to add spell data to the proc function if we need it, or we can just hardcode the procs

[Jabantiz]

Was looking at Blessed Weapon spell an noticed the proc has a duration (2sec stun) which this system can't handle, we could apply the stun but no way to remove it after 2 seconds. Looking for options on how to handle procs with durations, 3 options I came up with are:

Add an optional duration parameter to AddControlEffect, will work in this case but won't solve the problem if the proc is a DoT
Use a new spell for the portions with durations, would really suck making a spell from scratch
Make a new lua function for timers in spell scripts, no clue what this will involve, might add the most control while keeping everything in 1 spell script

Which one do you guys think would be the best? Any other ideas how to handle this?

[Jabantiz]

In a spell script the proc function will now receive the spell data

[John Adams]

Do we know why there is a duration1 and duration2 value? Are both used? If not, can duration2 be used for "secondary durations"?

[Jabantiz]

There are checks against duration2 in the code, no clue what it does off hand though, will look into it later today

[Jabantiz]

I lied about later today, took a quick look before I head out

It is used to determine a random duration between duration1 and duration2, if they are not equal

Code: Select all

int32 Spell::GetSpellDuration(){
	if(spell->duration1 == spell->duration2)
		return spell->duration1;

	int32 difference = 0;
	int32 lower = 0;
	if(spell->duration2 > spell->duration1){
		difference = spell->duration2 - spell->duration1;
		lower = spell->duration1;
	}
	else{
		difference = spell->duration1 - spell->duration2;
		lower = spell->duration2;
	}
	int32 duration = (rand()%difference) + lower;
	return duration;
}

[John Adams]

That's interesting. Ever heard of such a thing? I hadn't.... but it's a cool custom feature otherwise

The way I have been doing scripts, if the value of the "duration" of the effect is always the same across all tiers, I simply (wait for it...) hard-code the value in the script For example, if the duration of the stun is always 10 seconds across all tiers, then I stun the target for 10 right in the LUA script - no other functions needed. I thought that's what AddControlEffect() was for.