Page 1 of 1

Fae creations

Posted: Mon Nov 24, 2008 12:33 pm
by John Adams
I'll try a few more, but the one I just chose at random came into the game at the wrong coords, plus had no hair or wings. Ugly little sucker, too!
I am hearing reports from various new chars that they are appearing in the air over 0,0,0. I know I can use starting_zones to override, but I figured by default, we should know where every race/class is supposed to start.
Example: Fae, Troubadour, started on Queen's Colony standing over The Vulth (0,0,0) when the character create screen says it should have started in Kelethin. I'll look into the code to see if I can see what's happening.

Posted: Mon Nov 24, 2008 3:49 pm
by LethalEncounter
kk, will get to it as soon as I get back from trip.

Posted: Mon Nov 24, 2008 3:55 pm
by John Adams
No hurry, malformed toon creation is not on my top priority list. Just reporting the problem.

Posted: Tue Nov 25, 2008 12:44 pm
by John Adams
LE,
Here's a patch as my solution to the new character starting_zone issue. What's happened is when TessEQ2 changed all our zones.name values, it is still hard-coded to look for a zone by it's old name (ie., tutorial_island_good). I have changed this in 2 ways:
1) Modified the `zones` table to allow setting the value (1,2,4,8,16) for the client choice starting location.
Required SQL:

Code: Select all

alter table `zones` add column `start_zone` tinyint(3) NULL;
alter table `zones` add unique `StartZoneIDX` (`start_zone`);
update `zones` set `start_zone`='1' where `id`='253';  -- Queen's Colony
update `zones` set `start_zone`='2' where `id`='278';  -- Outpost of the Overlord
update `zones` set `start_zone`='4' where `id`='114';  -- Greater Faydark
update `zones` set `start_zone`='8' where `id`='184';  -- Neriak
update `zones` set `start_zone`='16' where `id`='263'; -- Timorous Deep
2) I removed the switch(choice) in WorldDatabase::UpdateStartingZone() and replaced it with 1 query that checks which zones the admin has set as a starting city (Queen's Colony, Outpost of the Overlord, Greater Faydark, Neriak or Timorous Deep). The `starting_zones` checks are still done first and if no match, this new query is run instead of the old switch(choice) which had hard-coded values.
Patch: Download
Tested and working so far on my dev server. Any input on making it better/smarter would be appreciated. And as usual, please remove my silly comments before you commit, if you do. It's just there to let you know what I was doing :)

Posted: Tue Nov 25, 2008 3:12 pm
by LethalEncounter
No, I don't see a better way to do it. This looks good. I'll add it to the update server and commit the changes to SVN.