spell icons in maintained window

[Zcoretri]

Spell icons in maintained window no longer display, you just get a colored background.

[LethalEncounter]

Yah I noticed that. I'll look into it.

[Zcoretri]

I coded it how it was before and it worked. Was there a reason behind why you created new functions?

[LethalEncounter]

Huh? Did I change something? I was going to work on getting buffs working but then got sidetracked, but I don't think I changed anything.

[Zcoretri]

Maybe those functions were already there, but here is what I am talking about...

Code: Select all

	//info->GetInfo()->maintained_effects[free_spell_maintained_slot].icon = (spell->GetSpellIcon()*-1)-1;
	info->GetInfo()->maintained_effects[free_spell_maintained_slot].icon = spell->GetSpellData()->icon;
	//info->GetInfo()->maintained_effects[free_spell_maintained_slot].icon_type = spell->GetSpellIconType();
	info->GetInfo()->maintained_effects[free_spell_maintained_slot].icon_type = spell->GetSpellData()->icontype;

commented out lines are what looked like were changed.

[LethalEncounter]

Feel free to grab an earlier version of the repository and test to see if it works, but I'm fairly certain it was broken before I made any changes.

[John Adams]

I remember debating the icons that showed up in Maintained before. If I cast a DoT on a mob, I would get a Maintained icon for that spell in my window - indefinitely. Zcoretri showed me that if my duration expired AFTER the mob died, the icon remained. But if before, the maintained icon would fade as expected.

Not sure if this helps any in remembering how it used to be.

[Zcoretri]

Feel free to grab an earlier version of the repository and test to see if it works, but I'm fairly certain it was broken before I made any changes.

Excuse my ignorance here, but how do you grab an earlier version?

[LethalEncounter]

I haven't done so it quite some time, but I think the process (if you are using tortoisesvn) is update to revision and then give the revision number. I think it will also show a log of the dates for each revision as well.

[Zcoretri]

AH, that's what that command does

Thank LE

[John Adams]

Also using TortoiseSVN, you can highlight the exact file you wish to compare, and do a Show Log, and it will only show you that files changes. You can then highlight 2 versions and right-click Compare and see a nice diff of the two files complete with highlighted differences.

[Zcoretri]

Yes I'm using TortoiseSVN...this sub version thing is pretty slick

OK, updated to rev 633 because 634 is where it was changed. Compiled and ran server, maintained window DOES show the icon correctly.

[LethalEncounter]

OK, just do a diff and change it back then. It isn't a big deal though, because even if the icon does show correctly buffs need a ton of work and I'm going to be working on them soon.

[Zcoretri]

OK, just do a diff and change it back then. It isn't a big deal though, because even if the icon does show correctly buffs need a ton of work and I'm going to be working on them soon.

Not soon enough...been wanting to do buffs for awhile now

OK will do a diff change

[John Adams]

Not soon enough...been wanting to do buffs for awhile now

Ahh, finally others are stepping up to my level of dev abuse!

My work here is done.