Spawn Movement/Lockups

[Scatman]

LE, John and I were on his server today testing out the quest database changes I made. We got on and noticed the spawn's movement animations appear to make them look like they are moving slow. When John is running in front of me, it looks like he is walking, but he is going the same speed as I am. I'm not sure if the spawns are actually moving slower or not though.

Also, we're getting a lot of ZoneServer::MSpawns deadlocks. It seemed to occur a lot whenever one of us was fighting. I /killed a bunch of spawns with no deadlock problems but as soon as John engaged a spawn in normal combat we got locked up. Maybe it is something to do with respawns? I had killed my spawns far before John engaged his.

The only code I changed was in WorldDatabase::LoadQuest and LuaInterface::LoadQuest so I can't imagine it'd be a problem with that ya think?

[LethalEncounter]

All your code checked in? I'll grab the latest and see if I can find the problem.

[LethalEncounter]

Oh and what type of deadlock, read or write?

[John Adams]

LE, Scat and I performed a little experiment. He logged into the server alone, zoned elsewhere. I logged into the original zone after it shut down.

We have NO issues now, even after he came back.

[Scatman]

It's checked in. We just tried it out on Tess, which is running public rev, and the spawns are moving slow there. We are back on dev with my changes and now we can't get the deadlock to occur . Hmm...I can't remember if it was read/write..John do you?

[LethalEncounter]

The slow speed might be cause by me messing with the movement code last week. Unless it is really annoying, just ignore it for now.

[John Adams]

Read Timeout waiting for write lock: ZoneServer::MClients

Also LE, give me a minute to commit some DB changes to the quests table, and check in the newest TessDB so you have exactly what we have.

5 mins.

[John Adams]

Ok, new minor version 27 for changes to `quests`. Checking in the Tess (Dev) DB now. All you really need here is the quests table. Your scripts should ignore RegisterQuest() after you get the new code, and I'll check in modified scripts soon as we verify them.

As for slow-motion mobs, yeah I can live with that. I cannot live with constant deadlocks and server non-responsiveness I'm just hoping it's nothing I caused!

[LethalEncounter]

Read Timeout waiting for write lock: ZoneServer::MClients

Also LE, give me a minute to commit some DB changes to the quests table, and check in the newest TessDB so you have exactly what we have.

5 mins.

Any idea what you were doing when it occurred?

[Scatman]

The first time it happened I was just running around. Not sure what John was doing.
The second time John had just attacked a spawn and it locked. I was just watching. I don't John ever got to kill it.

[LethalEncounter]

Are you sure that said "Read Timeout waiting for write lock: ZoneServer::MClients" and not MSpawns? I can't see how it could possibly give that error, unless something else is causing your server to get really slow.

[John Adams]

That is right from the console, so yes I am positive. Though I am also sure we've seen MSpawns too today, I just didn't have that after a restart.

[John Adams]

Ok, I have been on the phone about 2 hours, so while I was, I left myself logged in. At some point, Scatman fell offline. After he left, the next few lines in the console showed the deadlocks you are expecting.

Code: Select all

Unhandled command: afk
   0: 0C 00 11 00 6B 2C 20 74 - 68 61 74 27 73 63 6F 6D  | ....k, that'scom
  16: 6D 69 74 65 64                                     | mited
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
Creating Opcode 0 Packet!
Creating Opcode 0 Packet!
Creating Opcode 0 Packet!
Creating Opcode 0 Packet!
Creating Opcode 0 Packet!
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
Creating Opcode 0 Packet!
Creating Opcode 0 Packet!
Creating Opcode 0 Packet!
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
Creating Opcode 0 Packet!
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
Creating Opcode 0 Packet!
Creating Opcode 0 Packet!
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
Combined Packet: 3, 0
Combined Packet: 2, 0
Combined Packet: 3, 0
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: 71 01 00 00                                        | q...
Unhandled command: afk
Creating Opcode 0 Packet!
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: 36 00 00 00                                        | 6...
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: 25 00 01 00 30                                     | %...0
Creating Opcode 0 Packet!
Creating Opcode 0 Packet!
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
   0: C7 01 00 00                                        | ....
Unhandled command: clearallqueuedabilities
OP_BeginTrackingMsg Received 0x0175
Removing connection
Zone: Removing client from ip:68.45.201.93 port:3430
   0: 71 01 00 00                                        | q...
Unhandled command: afk
   0: 71 01 00 00                                        | q...
Unhandled command: afk
Timeout waiting for read locks: ZoneServer::MSpawns
Possible deadlock attempt by 'ZoneServer::MSpawns'!
Timeout waiting for read locks: ZoneServer::MSpawns

I don't know if Scat was doing anything, but I was totally AFK during this time, from before he said committed, til posting this post.

[Scatman]

I wasn't doing anything. I logged off for dinner.

[LethalEncounter]

I think I found the cause, I'll check it in with the spawn stuff (hopefully tonight or tomorrow).