/spawn combine add/save

Old bugs stored here for reference.
Locked
User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

/spawn combine add/save

Post by John Adams » Mon Feb 15, 2010 11:51 am

I am targetting 1 spawn, typing

Code: Select all

/spawn combine add
Then targetting a second spawn and again typing

Code: Select all

/spawn combine add
and when I type

Code: Select all

/spawn combine save
the new spawn location group is splitting the 2 spawns at 66/33, when it should be 50/50. Shouldn't it?

User avatar
John Adams
Retired
Posts: 9684
Joined: Thu Jul 26, 2007 6:27 am
EQ2Emu Server: EQ2Emulator Test Center
Characters: John
Location: Arizona
Contact:

Re: /spawn combine add/save

Post by John Adams » Mon Feb 15, 2010 12:08 pm

I *think* this might be caused by the total=1 init value.

In WorldDatabase::SaveCombinedSpawnLocation, we init int32 total = 1, then total++ it as we iterate through everything that's been added.

If it starts out as a 1, then bumps to a 2 when the first NPC is added, then we add the third and it's now 3, then yes the first spawn does appear to have 66% and the last one 33%.

I won't even ask what happened to that last 1% ;)

User avatar
Scatman
Retired
Posts: 1688
Joined: Wed Apr 16, 2008 5:44 am
EQ2Emu Server: Scatman's Word
Characters: Scatman
Location: New Jersey

Re: /spawn combine add/save

Post by Scatman » Mon Feb 15, 2010 2:40 pm

Should be fixed.

Locked

Who is online

Users browsing this forum: No registered users and 0 guests