Page 1 of 1

/spawn combine add/save

Posted: Mon Feb 15, 2010 11:51 am
by John Adams
I am targetting 1 spawn, typing

Code: Select all

/spawn combine add
Then targetting a second spawn and again typing

Code: Select all

/spawn combine add
and when I type

Code: Select all

/spawn combine save
the new spawn location group is splitting the 2 spawns at 66/33, when it should be 50/50. Shouldn't it?

Re: /spawn combine add/save

Posted: Mon Feb 15, 2010 12:08 pm
by John Adams
I *think* this might be caused by the total=1 init value.

In WorldDatabase::SaveCombinedSpawnLocation, we init int32 total = 1, then total++ it as we iterate through everything that's been added.

If it starts out as a 1, then bumps to a 2 when the first NPC is added, then we add the third and it's now 3, then yes the first spawn does appear to have 66% and the last one 33%.

I won't even ask what happened to that last 1% ;)

Re: /spawn combine add/save

Posted: Mon Feb 15, 2010 2:40 pm
by Scatman
Should be fixed.