Page 1 of 1

BugID: 317

Posted: Wed Mar 24, 2010 10:40 am
by elcapototal
Not sure how to send code fixes for small bugs. Diffs are a pain in the butt for 1-liners so for the time being I'm just going to post the new code and line numbers. if this doesn't work for you guys let me know and I'll just generate the diffs.

Fix for 317 (/summon bug):

Client.cpp
Summon function
added lines 1867 & 1868

Code: Select all

1866.			target = GetCurrentZone()->FindSpawn(GetPlayer(), search_name);
1867.			if(target && target->IsPlayer())
1868.				search_client = GetCurrentZone()->GetClientBySpawn(target);
1869.			if(!target){
1870.				search_client = zone_list.GetClientByCharName(string(search_name));
1871.				if(search_client)
1872.					target = search_client->GetPlayer();
1873.			}

Re: BugID: 317

Posted: Wed Mar 24, 2010 11:01 am
by John Adams
Please generate diffs for code submissions. If you are using TortoiseSVN client, it is as easy as highlighting the Source dir and Create patch. The reason this is important is that our line #'s are likely not going to match the public SVN, and I do not want our dev(s) diving through code making guesses - diffs are fairly standard, so I am sure you'll understand.

Let us know if you have any questions about this. And thank you in advance for the code fixes!

Re: BugID: 317

Posted: Wed Mar 24, 2010 11:39 am
by elcapototal
attached patch

Re: BugID: 317

Posted: Wed Mar 24, 2010 11:45 am
by John Adams
Awesome, thank you. These take a little longer than simple DB updates to apply :) Give is a few to sort it out.

SCAT!