DoV (1096) Water issues

[Jabantiz]

I was able to identify an unknown element in the char sheet for how long the player can hold their breath underwater so now chars won't drown after 1 sec, updated the struct and have it as a hardcoded value (30 sec, but might be good to make this a rule).

The other water issue was using /speed you would stop moving as soon as you would start swimming and essentially be stuck, this has also been fixed, the problem was speed sent a WS_SetControlGhost and never set any of the unknowns, setting unknown to .5408 (from a 1096 log) it works. This unknown might be used to multiply the speed value when in water, but that is just a guess at this point.

As usual all fixes have been commited to dev svn.

[Scatman]

Does your swimming skill affect your ability to hold your breath (higher swimming skill -> more breath) on live?

[Jabantiz]

I honestly have no idea on that, I think swimming skill effects speed but I am not sure on that either.

[Zcoretri]

Does your swimming skill affect your ability to hold your breath (higher swimming skill -> more breath) on live?

I don't think so, no. It makes you swim faster I believe.

[JCL]

Swimming skill only affects the swim speed.

[John Adams]

Ok, so general consensus is:

- swimming skills increase your movement speed
- spells/abilities/traits make you hold your breath longer/indefinitely

Anything else?