Page 1 of 1
[FIXED]AddSkillBonus
Posted: Mon Aug 05, 2013 11:16 am
by Jabantiz
Noticed this in irc last night and looked into it.
Some spell store values as a float, which is sent to the lua script to be used in this function. However this function does not accept floats, only sint16 for value. A simple hack to fix this would be easy but to do it properly a lot of variable types need to be changed, I will work on this later today.
Re: AddSkillBonus
Posted: Mon Aug 05, 2013 1:14 pm
by John Adams
You know my entire existence is to generate more work for you, Jabantiz.
Thank you.
Re: AddSkillBonus
Posted: Mon Aug 05, 2013 9:59 pm
by Jabantiz
Committed a fix. Would like to point out that the packet that sends skill values takes an int16 so you will not see the decimals in the client.
Re: AddSkillBonus
Posted: Tue Aug 06, 2013 6:36 am
by John Adams
If the client only displays int16, what's the point of us using floats? Just so our local calcs are more accurate? Also, does this mean if I have a 1.9% stat, it's going to show as "1"? lol
Re: AddSkillBonus
Posted: Tue Aug 06, 2013 11:20 am
by Jabantiz
John Adams wrote:If the client only displays int16, what's the point of us using floats? Just so our local calcs are more accurate? Also, does this mean if I have a 1.9% stat, it's going to show as "1"? lol
We use floats because live uses them... our calcs will be more accurate now, when we get around to using the skills in equations And yes it will probably show as 1 when it is 1.9