Page 1 of 1
Bring out your dead
Posted: Fri Mar 24, 2017 8:55 am
by Gangrenous
We have had this issue a while now, really needs to get resolved. I do not know if it is every time, but this happens.
death.jpg
Notice the stacked bodies? Also the combat seems to quit reacting properly. I am getting hit, but nothing in the client log. I will try to find a common theme, but so far I have just done cursory glances at what could be causing it.
Re: Bring out your dead
Posted: Fri Mar 24, 2017 9:09 am
by Gangrenous
Okay, so more information. It seems to happen on your first death. If you level up, heal, camp and then restart the server you are okay. On the first death, you see the combat hits going on the client. Your energy is represented above your character. After the first death, the bar above your character quits working. Go into combat like this and you will die, and nothing shows as happening on the screen. The monsters do not swing and no activity under the client's combat window.
Re: Bring out your dead
Posted: Fri Mar 24, 2017 3:50 pm
by Jabantiz
I know of this issue but I can not reproduce it reliably, some report it happens all the time other it is rare, in my case it is rare and I can't figure out why it happens or why it seems to happen more often for some then others.
Re: Bring out your dead
Posted: Fri Mar 24, 2017 7:16 pm
by Gangrenous
Tried multiple zones, happens every time for me. Tried a new character, same thing. Tried reverting my source back to the first version I have of my source and did a /make clean and /make -j5 and same thing. Also, not just logging in and out fixes it. Zoning also fixes it.
If you set revive_points outside of your current zone, that does seem to fix at least some of the issues.
Re: Bring out your dead
Posted: Sat Mar 25, 2017 8:12 am
by Gangrenous
This fixes it... I am sure I can clean it up more, after I exercise and work on my yard I will edit the post.
Code: Select all
//revive at zone safe coords
if(!revive_point)
{
LogWrite(CCLIENT__WARNING, 0, "Client", "No Revive Point! Spawning player at safe coordinates!");
x = GetCurrentZone()->GetSafeX();
y = GetCurrentZone()->GetSafeY();
z = GetCurrentZone()->GetSafeZ();
heading = GetCurrentZone()->GetSafeHeading();
zone_desc = GetCurrentZone()->GetZoneDescription();
location_name = "Zone Safe Point";
player->ClearEverything();
Zone(GetCurrentZone()->GetZoneName(), false);
}
Re: Bring out your dead
Posted: Sat Mar 25, 2017 3:10 pm
by Jabantiz
Xinux pointed me to probably the same function last night and after going over it that entire function doesn't make much sense and I think it need to be entirely reworked.
Also does this mean that there is only an issue when the zone has no revive points and everything works fine when there is a revive point?
Re: Bring out your dead
Posted: Sat Mar 25, 2017 3:29 pm
by Gangrenous
It only works when the revive point is in another zone. Trickling through it all, this is what it needs...
Code: Select all
ClientPacketFunctions::SendZoneChange
When that is sent, it seems to fix the issue. I do not know the code like you guys do, I am just experimenting at this point.
Re: Bring out your dead
Posted: Sat Jan 06, 2018 10:03 pm
by Cynnar
Gangrenous wrote: Fri Mar 24, 2017 9:09 am
After the first death, the bar above your character quits working. Go into combat like this and you will die, and nothing shows as happening on the screen. The monsters do not swing and no activity under the client's combat window.
I noticed that the fighting animation not working is back. I noticed it on the emu server while testing out Queen's Colony today. I did notice that I was doing damage while fighting, but the animation wasn't working.
Re: Bring out your dead
Posted: Sat Jan 06, 2018 10:12 pm
by Jabantiz
Something really goes wrong after death as /bot customize stops working if you die and release (if you are rezzed there is no issues) and that command overwrites the three main structs temporarily, the fact that it stops working after a death means something is getting seriously broken when you revive.
Re: Bring out your dead
Posted: Sat Jan 06, 2018 10:18 pm
by Cynnar
It's not one of those areas that need to be rewritten is it?
Re: Bring out your dead
Posted: Sat Jan 06, 2018 10:25 pm
by tyrbo
Cynnar wrote: Sat Jan 06, 2018 10:03 pm
I noticed that the fighting animation not working is back. I noticed it on the emu server while testing out Queen's Colony today. I did notice that I was doing damage while fighting, but the animation wasn't working.
Not seeing that on my server at all. That's weird.