Page 1 of 1

BUG: extra combat messages displayed in client

Posted: Sat May 04, 2019 7:45 am
by Ememjr
double.JPG
on every spell damages spell i seem to cast i cast as seen above i get the proper "Your Icefall hits an Oakmyst fawn for 37 cold damage."

but then also get another that always fails to inflict "Your Icefall hits an Oakmyst fawn but fails to inflict any damage."

also getting a double blue message.

also noticed if you are in the zone near the combat as a bystander, you are seeing the blue messages, as a bystander,and infact even if your in the group only the caster should ever see the blue message,

I have confirmed this on live

i have trace the spell through code, and found that in fact the SpellAttack function is only executed once, but we are sending the SendDamagePacket packet twice once in combat.cpp around line 937via the damagespawn function sent aroun 392, then it is sent again at 406
the one at 406 is always sending 0 damage

i will be trying to figue out which one is not needed as we should not be sending it twice