Page 1 of 1

World server crash bug

Posted: Wed Mar 04, 2020 5:43 am
by Cadimiom
There was an issue with out of order packets (sequencing code in EQStream) that caused an infinite loop and crashed if you were in a zone for too long...:

[204.204.204.204:52428->204.204.204.204:52428] [Seq=0] [OpCode 0x0009 (OP_Unknow
n) Size=16]

eg. that seq number would go up to the uint16 cap then crash.

This fixes us to not indefinitely keep sequencing the same packet over and over (preventing said crash):
http://cutpon.com:3000/devn00b/EQ2EMu/c ... cb9caec3c0

Edit: To note there are some eqemu log calls commented out in the new functions. I was hoping at a later time to revisit EQStream to touch up some other things. But this was crashing the entire world server when the client did this so seemed important to push out (least in my git for the team we have).

Re: World server crash bug

Posted: Wed Mar 04, 2020 4:59 pm
by Jabantiz
Thanks for the fix, it is committed to dev svn and will be up on the emu server soon.

Side note, is is nice to see code actually coming back to the project for a change so thank you for this.

Re: World server crash bug

Posted: Mon Mar 16, 2020 6:02 pm
by John Adams
Cadimiom wrote: Wed Mar 04, 2020 5:43 am [204.204.204.204:52428->204.204.204.204:52428] [Seq=0] [OpCode 0x0009 (OP_Unknow
n) Size=16]

eg. that seq number would go up to the uint16 cap then crash.

This fixes us to not indefinitely keep sequencing the same packet over and over (preventing said crash):
How the heck do you remember this stuff from 15 YEARS ago? After 10 years, I retired from this in 2016, and can barely remember the domain name :mrgreen:

Re: World server crash bug

Posted: Tue Mar 17, 2020 1:20 pm
by Cadimiom
John Adams wrote: Mon Mar 16, 2020 6:02 pm
Cadimiom wrote: Wed Mar 04, 2020 5:43 am [204.204.204.204:52428->204.204.204.204:52428] [Seq=0] [OpCode 0x0009 (OP_Unknow
n) Size=16]

eg. that seq number would go up to the uint16 cap then crash.

This fixes us to not indefinitely keep sequencing the same packet over and over (preventing said crash):
How the heck do you remember this stuff from 15 YEARS ago? After 10 years, I retired from this in 2016, and can barely remember the domain name :mrgreen:
Probably cause these are the only things I remember lol.. I forget plenty of other stuff.

You can thank devn00b for deciding to delve in eq2emu and plan to host a pvp server on www.zeklabs.com cause otherwise I wouldn't have probably been involved as I don't like doing emulation projects solo.