Page 1 of 6

Task: Zone "Friendly" Names

Posted: Fri Sep 05, 2008 6:09 pm
by John Adams
Many of the zones `name` values are very cryptic and cumbersome to type, and we are looking to make the `name` column more user friendly. I'd like to find someone to take the time to create these friendly names and edit them in our database. These will become the official /zone command names, so they need to be unique and well thought out.
Examples:

Code: Select all

/zone QueensColony     vs /zone tutorial_island_good
/zone OverlordOutpost  vs /zone tutorial_island_evil
/zone exp03_dun_mistmoore_catacombs_epic02_oldcatacombs vs /zone CryptOfValdoon
I do not think "case" is important (QueensColony vs queenscolony) but it's clearer when looking it up or using the /zone list command. Spelling accuracy is a must. If you can't spell, please don't offer to fix our zone names. :)
These changes are not mandatory, and there is no hurry to get them changed over. If no one volunteers to take on this task, the DB Team will simply change the zone `name` data each time a new zone is released. I thought it would be better to implement this change up front so admins and players become familiar with them before we get too much further.

Posted: Fri Sep 05, 2008 7:24 pm
by ZexisStryfe
I would be more than happy to take care of this.
Should I do it on my server and give you the changes, or do you want to give me access to your database?

Posted: Sat Sep 06, 2008 6:37 am
by Arremis
Currently I'm already using the present naming system for the zone mod of the Admin Panel. With me working on this part of the project at the moment, would this database revamp be necessary? Once the clicky doors are in place, the only people who would really need the zone commands would be Admins and GMs.
On the other hand, it wouldn't be difficult to change the zone mod to fit the new naming system.

Posted: Sat Sep 06, 2008 9:31 am
by John Adams
Yeah, I definitely want the "friendly names" more friendly. Sorry if that puts you in a bind, Arremis. Maybe in your tool you should just use zone_id, since anyone who gets the emu running has the option to change those names to anything they want?
And while true that only admins and GMs *might* use the /zone command, it is not really a guarentee. Who knows how someone might set up their server.
Zexis, thank you. Either way is good for me, since zone_id's are static across all emulators (so far heh). I will PM you DB creds in case you want to just to it on Tess' DB. Today I am adding a full zone list (quick lookup) since this is changing, our editors will need to know how to get around. :D

Posted: Sat Sep 06, 2008 12:09 pm
by John Adams
Zones editor update is complete and it is again available. Give it a try if you choose, otherwise I'll wait for your entire `zones` table MySQL dump.

Posted: Sun Sep 07, 2008 10:38 am
by John Adams
LE, when the WorldDatabase::Save(Client* client) runs, it appears whatever the player typed into the /zone {name} command is what is getting saved to the database - case-sensitive.
The problem with not fetching the true `name` from the zones table, and using player input, is that apparently there is a difference between "queenscolony" and "QueensColony". The net result is 2 players in the same zone, only different "instances" if you will. This caused Scatman and I to be cleaning the same sets of spawns but of course not getting updates until we repopped.
Now that we know, it's no big deal to zone properly - but maybe we can consider not relying on what the player types in for `characters`.`current_zone`, because it appears to be firing off separate instances instead of using the one that's active.
Sorry, don't mean for everything I do to become a bug (hehe)... I am looking at the update query now, line 1952 of WorldDatabase.cpp. The param is client->GetCurrentZoneName(). Maybe we need to tap the `zones` table real quick to get the ACTUAL zone `name` value?
Thanks,
-J

Posted: Sun Sep 07, 2008 3:34 pm
by LethalEncounter
OK, I'll fix it in both locations (where it saves the client as well as where it determines which zone to retrieve).

Posted: Sun Sep 07, 2008 3:46 pm
by John Adams
Thank you, sir :)

Posted: Tue Sep 09, 2008 12:16 am
by Arremis
Just an observation, but whenever I zone to Antonica, it always lands me at the bell on the docks. Are there any provisions made for zoning to the same zone, but different locations? I wouldn't want to be evil and zone out of stormhold just to land on the docks next to the qeynos guard :shock:

Posted: Tue Sep 09, 2008 6:14 am
by John Adams
I assume you are using /zone? If so, that is not how players will be moving through zones - the /zone command is for admins/GMs and drops you at the zones "safe_*" coords set in the zones table. I am sure that eventually we can ask for "/zone {name|id} [x,y,z]", but for now it works as designed.
fwiw, the term "safe" in regards to coordinates should imply it is safe for all races/factions to land. If not, move your safe_x, safe_y, safe_z elsewhere.

Posted: Wed Sep 10, 2008 7:06 am
by ZexisStryfe
John,
I have going through doing the database doing the zone friendly names, and I noticed that The Crypt of Agony is missing from the list. This zone is a heroic instance of Protector's Realm, so could you copy all the info from the Protector's Realm entry to a new id so I can set up the Crypt of Agony zone instance too?

Posted: Wed Sep 10, 2008 7:31 am
by John Adams
Done. New zone_id = 303.
I will eventually allow the ability to insert/delete zones from that list, especially with upcoming expansions.
PM you some additional info.

Posted: Wed Sep 10, 2008 7:36 am
by ZexisStryfe
Thanks, I am done with the current list and going to work on some of the "Describe Me's". I noticed several other zones missing that are instances (Nizara, Nek Castle 2, Nek Castle 3, Trenda's Lair, etc) so I am going to enter those as soon as you let me

Posted: Wed Sep 10, 2008 7:41 am
by John Adams
Go for it, anything you need to enter, you should have full access to the DB now.

Posted: Wed Sep 10, 2008 9:11 pm
by ZexisStryfe
Just got the full zone list off allakhazam... 416 zones, so we are only missing 116 of them.
I am going to do my best and make sure all the zones in the database are correct, and then I am going to add the different instances (such as the 10 versions of splitpaw). Hopefully I should come close to all 416 by the time I am done.
Man, I have my work cut out for me... :P